[modules-dev] Review request for 6588155 (fixes to borken tests)
Kumar.Srinivasan at Sun.COM
Wed Aug 1 15:33:27 PDT 2007
> What's in the webrev fixes the current problems: we'll likely have to apply
> further fixing when we figure out exactly how to go about that. This is only
> supposed to be enough to fix the current set of known, demonstratable problems.
I am wondering how the toURI method is not choking on the spaces, thats all.
> I talked with Alan this morning, and did some experimenting, but am not ready
> to provide a complete fix for the "spaces in filename" issue yet.
> If you want me to fix that as part of this, just let me know, though that will
> delay integrating this until next week.
Nope this is fine for now.
>>> Hi folks,
>>> This fixes the broken tests, and, at least temporarily, resolves the
>>> issue which fixing those tests revealed in JamUtils.getFile(). The
>>> changes are all very small: could someone please take a look?
>>> webrev: http://analemma.sfbay.sun.com/java/jdk/ws/libs/rev/6588155/
>>> bugster: http://monaco.sfbay/detail.jsf?cr=6588155
>>> Aside from the relatively straightforward fixes:
>>> * Makefile: Changed so that the mkdir's output is in the log; when
>>> first investigating the problem I wondered if perhaps the target's
>>> action had not been executed
>>> * RepositoryConfig: Now yields useful output from the
>>> modules-dev mailing list
>>> modules-dev at openjdk.java.net
> modules-dev mailing list
> modules-dev at openjdk.java.net
Sun Microsystems, Java Software.
More information about the modules-dev