[modules-dev] Review request: 6559092
Stanley M. Ho
Stanley.Ho at Sun.COM
Thu Jul 12 14:25:38 PDT 2007
Looks good. Several comments inline:
I think rather than creating a fake system repository if one doesn't yet
exist, it would be better to simply use the bootstrap repository as the
default system repository, i.e.
private static Repository systemRepository =
Then if the module launcher needs to change the system repository later,
it could simply reset it, e.g.
repository = Modules.newLocalRepository(
81 check(systemRepo.getParent() ==
This check would break as soon as the repository configuration file
support is in place, but should be okay for now.
More information about the modules-dev