[modules-dev] Review request: 6559092
David.Bristor at Sun.COM
Thu Jul 12 16:51:10 PDT 2007
Stanley M. Ho wrote:
> Dave Bristor wrote:
>> That would mean that the system repository could be changed at will.
>> The intention of the proposed change was that the system repository
>> could be set at most once. Do we really want to allow that? If so,
>> should we do any checks to be sure that the bootstrap repository is
>> reachable from the argument given to setSystemRepository? Or, we
>> could add some other field to indicate whether setSystemRepository has
>> ever been invoked, and allow it to be invoked at most once/JVM.
> The system repository could not and should not be changed externally,
> and there is no public setSystemRepository API in the Repository class.
> Internally, the system repository should only be set at most once
> through the RepositoryConfig.setSystemRepository method. Adding a flag
> sounds like a reasonable approach.
I've combined our approaches: no more fake system repository, and a flag to
ensure setSystemRepository succeeds only once.
I updated the webrev:
> - Stanley
More information about the modules-dev