[modules-dev] Review request for 6578988
David.Bristor at Sun.COM
Tue Oct 9 13:28:47 PDT 2007
This fix for
(repo) Implement Repository.shutdownOnExit
builds on top of my previous request (attached); it has build atop that
because the changes here for shutdownOnExit() rely on the changes to
shutdown() in the prior request.
This is a *lot* shorter than my previous request. It includes some javadoc
fixes in JamUtils.
You'll see in the change that when shutdownOnExit is invoked with false, that
any previously-created shutdownThread is made available to GC. I didn't see
any reason to retain the reference if the likelihood is that it won't be used.
It might be better to keep it once created. Space v. time!
I submitted a JPRT run that has changes for this fix plus the others.
-------------- next part --------------
An embedded message was scrubbed...
From: Dave Bristor <David.Bristor at Sun.COM>
Subject: Review request for 6559067, 6559086, and 6605100
Date: Fri, 05 Oct 2007 15:55:54 -0700
More information about the modules-dev