[modules-dev] Review request for 6608500
Stanley M. Ho
Stanley.Ho at Sun.COM
Wed Sep 26 12:07:30 PDT 2007
Looks good. A few comments:
The value of the system property should be retrieved within a
doPrivileged block, otherwise it will fail when it runs inside the sandbox.
Also, this should be done once, possibly in a static initializer, so we
don't need to keep checking the system property whenever a new
repository is initialized.
228 expansionDirectory = value == null ? sourceDirectory : new
It is unclear why the path of the expansion directory is derived from
the source directory. I would expect that the expansion directory is
somewhere in temp.
Dave Bristor wrote:
> Hi folks,
> This cleans up some tests. It includes the changes we mentioned yesterday
> w.r.t. *Repository implementations: they can now be configured from system
> properties, and those values override values in the Map<String, String> that's
> provided when the instance is created. These changes should keep old test
> files from filling JPRT's temp directories.
> bugster: http://monaco.sfbay/detail.jsf?cr=6608500
> webrev: http://analemma.sfbay.sun.com/java/jdk/ws/libs/rev/6608500/
> Please note that, with respect to configuring repositories use of the Map is
> still in LocalRepositoryTest and URLRepositoryTest. Testing via
> System.getProperty is in BasicLauncherTests.
> modules-dev mailing list
> modules-dev at openjdk.java.net
More information about the modules-dev