Code review for 6644726: Cookie management issues
Christopher Hegarty - Sun Microsystems Ireland
Christopher.Hegarty at Sun.COM
Wed Apr 16 02:53:47 PDT 2008
This change looks good.
Jean-Christophe Collet wrote:
> Here are my proposed changes to fix 6644726
> It does fix all 7 issues listed in the CR (see
> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6644726 for details)
> and adds a proper regression test.
> The short list is:
> - support for more 'expires' date format
> - enforce 'secure' cookies
> - enforce the 'port' optional attribute
> - set a default 'path' when none is specified as per RFC requirement
> - do not apply strict RFC 2965 rules for domain matching when cookie
> version is 0 (aka Netscape compliant cookies)
> - set a default path for cookies
> - do not use scheme and port for identifying cookies (i.e. cookies cross
> over protocols like http & https, or ports)
> Patch attached below.
More information about the net-dev