From Bradford.Wetmore at Sun.COM Thu May 1 15:42:04 2008 From: Bradford.Wetmore at Sun.COM (Brad Wetmore) Date: Thu, 01 May 2008 15:42:04 -0700 Subject: JSN/TL integration slot pushed back 1 week. Message-ID: <481A473C.80800@sun.com> Because of JavaOne being next week, we'll be doing an integration the week after J1 instead of next week. Brad From christopher.hegarty at sun.com Fri May 2 13:44:52 2008 From: christopher.hegarty at sun.com (christopher.hegarty at sun.com) Date: Fri, 02 May 2008 20:44:52 +0000 Subject: hg: jdk7/jsn/jdk: 6687919: REGRESSION : Classloader can handle any resource which is not included in classpath Message-ID: <20080502204504.9131C27BCF@hg.openjdk.java.net> Changeset: d95a6a4ea502 Author: chegar Date: 2008-05-02 21:33 +0100 URL: http://hg.openjdk.java.net/jdk7/jsn/jdk/rev/d95a6a4ea502 6687919: REGRESSION : Classloader can handle any resource which is not included in classpath Reviewed-by: jccollet, alanb ! src/share/classes/sun/misc/URLClassPath.java From mvyskocil at suse.cz Sat May 10 05:29:18 2008 From: mvyskocil at suse.cz (Michal Vyskocil) Date: Sat, 10 May 2008 14:29:18 +0200 Subject: Symbol ``['' and a java.net.URI.create method In-Reply-To: <48174B17.8010606@Sun.COM> References: <200804291730.46932.mvyskocil@suse.cz> <481745E4.8010406@Sun.COM> <48174B17.8010606@Sun.COM> Message-ID: <200805101429.21255.mvyskocil@suse.cz> On Tuesday 29 April 2008 18:21:43 Christopher Hegarty - Sun Microsystems Ireland wrote: > The square bracket characters ('[' and ']') are reserved characters > in a URI. If they are to be used then they need to percent encoded. > That is, '[' is percent encoded to be %5B. > > The single argument java.net.URI constructor requires any illegal > characters in its argument to be quoted and preserves any escaped > octets and other characters that are present. The static create > method simply invokes the URI(String) constructor, with some extra > Exception handling. Therefore any reserved characters need to be > percent encoded before passing the String as an argument. > > You can look at the java.net.URI class description to give you a > better understanding of how this encoding works. Hi Chriss, thanks for your response. There problem was in ant. There are two bugs - missing encodeUri and a decodeUri calls in a org.apache.tools.ant.launch.Locator.createUri - both was fixed in upstream - r539002 and r533024. For ant 1.7.0 is this simple patch, just --- src/main/org/apache/tools/ant/launch/Locator.java +++ src/main/org/apache/tools/ant/launch/Locator.java @@ -159,11 +159,14 @@ try { java.lang.reflect.Method createMethod = uriClazz.getMethod("create", new Class[] {String.class}); - Object uriObj = createMethod.invoke(null, new Object[] {uri}); + // encode URI first - to handle [] characters used in a + // build-jar-repository in jpackage project + Object uriObj = createMethod.invoke(null, new Object[] {encodeURI(uri)}); java.lang.reflect.Constructor fileConst = File.class.getConstructor(new Class[] {uriClazz}); File f = (File) fileConst.newInstance(new Object[] {uriObj}); - return f.getAbsolutePath(); + //bug #42227 (Apache bugzilla) forgot to decode before returning + return decodeUri(f.getAbsolutePath()); } catch (java.lang.reflect.InvocationTargetException e) { Throwable e2 = e.getTargetException(); if (e2 instanceof IllegalArgumentException) { Thanks for help! Regards Michal Vyskocil From Christopher.Hegarty at Sun.COM Sat May 10 07:58:13 2008 From: Christopher.Hegarty at Sun.COM (Christopher Hegarty - Sun Microsystems Ireland) Date: Sat, 10 May 2008 07:58:13 -0700 Subject: Symbol ``['' and a java.net.URI.create method In-Reply-To: <200805101429.21255.mvyskocil@suse.cz> References: <200804291730.46932.mvyskocil@suse.cz> <481745E4.8010406@Sun.COM> <48174B17.8010606@Sun.COM> <200805101429.21255.mvyskocil@suse.cz> Message-ID: <4825B805.9070406@sun.com> Thanks for the update Michal. It is nice to know that even though this was not our bug we were able to help diagnose the problem. -Chris. Michal Vyskocil wrote: > On Tuesday 29 April 2008 18:21:43 Christopher Hegarty - Sun Microsystems > Ireland wrote: >> The square bracket characters ('[' and ']') are reserved characters >> in a URI. If they are to be used then they need to percent encoded. >> That is, '[' is percent encoded to be %5B. >> >> The single argument java.net.URI constructor requires any illegal >> characters in its argument to be quoted and preserves any escaped >> octets and other characters that are present. The static create >> method simply invokes the URI(String) constructor, with some extra >> Exception handling. Therefore any reserved characters need to be >> percent encoded before passing the String as an argument. >> >> You can look at the java.net.URI class description to give you a >> better understanding of how this encoding works. > > Hi Chriss, > > thanks for your response. There problem was in ant. There are two bugs - > missing encodeUri and a decodeUri calls in a > org.apache.tools.ant.launch.Locator.createUri - both was fixed in > upstream - r539002 and r533024. > > For ant 1.7.0 is this simple patch, just > > --- src/main/org/apache/tools/ant/launch/Locator.java > +++ src/main/org/apache/tools/ant/launch/Locator.java > @@ -159,11 +159,14 @@ > try { > java.lang.reflect.Method createMethod > = uriClazz.getMethod("create", new Class[] > {String.class}); > - Object uriObj = createMethod.invoke(null, new Object[] > {uri}); > + // encode URI first - to handle [] characters used in a > + // build-jar-repository in jpackage project > + Object uriObj = createMethod.invoke(null, new Object[] > {encodeURI(uri)}); > java.lang.reflect.Constructor fileConst > = File.class.getConstructor(new Class[] > {uriClazz}); > File f = (File) fileConst.newInstance(new Object[] > {uriObj}); > - return f.getAbsolutePath(); > + //bug #42227 (Apache bugzilla) forgot to decode before > returning > + return decodeUri(f.getAbsolutePath()); > } catch (java.lang.reflect.InvocationTargetException e) { > Throwable e2 = e.getTargetException(); > if (e2 instanceof IllegalArgumentException) { > > Thanks for help! > > Regards > Michal Vyskocil From Bradford.Wetmore at Sun.COM Mon May 12 08:03:54 2008 From: Bradford.Wetmore at Sun.COM (Brad Wetmore) Date: Mon, 12 May 2008 08:03:54 -0700 Subject: Any more putbacks for this week's integration? Message-ID: <48285C5A.7070801@sun.com> Let me know soon, I'd like to start the builds. Brad From bradford.wetmore at sun.com Mon May 12 13:37:47 2008 From: bradford.wetmore at sun.com (bradford.wetmore at sun.com) Date: Mon, 12 May 2008 20:37:47 +0000 Subject: hg: jdk7/jsn/jdk: 5 new changesets Message-ID: <20080512203858.D0F6827EEE@hg.openjdk.java.net> Changeset: a3b3f07682b5 Author: kamg Date: 2008-05-08 09:16 -0400 URL: http://hg.openjdk.java.net/jdk7/jsn/jdk/rev/a3b3f07682b5 6697875: Copyright headers need to be upgraded with GPL derivative Summary: Update copyright headers to GPL Reviewed-by: xdono ! make/com/sun/tracing/Makefile ! make/com/sun/tracing/dtrace/Makefile ! make/sun/tracing/Makefile ! make/sun/tracing/dtrace/Makefile ! make/sun/tracing/dtrace/mapfile-vers ! src/share/classes/com/sun/tracing/Probe.java ! src/share/classes/com/sun/tracing/ProbeName.java ! src/share/classes/com/sun/tracing/Provider.java ! src/share/classes/com/sun/tracing/ProviderName.java ! src/share/classes/com/sun/tracing/dtrace/ArgsAttributes.java ! src/share/classes/com/sun/tracing/dtrace/Attributes.java ! src/share/classes/com/sun/tracing/dtrace/DependencyClass.java ! src/share/classes/com/sun/tracing/dtrace/FunctionAttributes.java ! src/share/classes/com/sun/tracing/dtrace/FunctionName.java ! src/share/classes/com/sun/tracing/dtrace/ModuleAttributes.java ! src/share/classes/com/sun/tracing/dtrace/ModuleName.java ! src/share/classes/com/sun/tracing/dtrace/NameAttributes.java ! src/share/classes/com/sun/tracing/dtrace/ProviderAttributes.java ! src/share/classes/com/sun/tracing/dtrace/StabilityLevel.java ! src/share/classes/com/sun/tracing/dtrace/package-info.java ! src/share/classes/com/sun/tracing/package-info.java ! src/share/classes/sun/tracing/MultiplexProviderFactory.java ! src/share/classes/sun/tracing/NullProviderFactory.java ! src/share/classes/sun/tracing/PrintStreamProviderFactory.java ! src/share/classes/sun/tracing/ProbeSkeleton.java ! src/share/classes/sun/tracing/ProviderSkeleton.java ! src/share/classes/sun/tracing/dtrace/Activation.java ! src/share/classes/sun/tracing/dtrace/DTraceProbe.java ! src/share/classes/sun/tracing/dtrace/DTraceProvider.java ! src/share/classes/sun/tracing/dtrace/DTraceProviderFactory.java ! src/share/classes/sun/tracing/dtrace/JVM.java ! src/share/classes/sun/tracing/package-info.java ! src/share/native/sun/tracing/dtrace/JVM.c ! src/share/native/sun/tracing/dtrace/jvm_symbols.h ! src/solaris/native/sun/tracing/dtrace/jvm_symbols_md.c ! src/windows/native/sun/tracing/dtrace/jvm_symbols_md.c Changeset: d64b14c25c82 Author: martin Date: 2008-05-10 11:30 -0700 URL: http://hg.openjdk.java.net/jdk7/jsn/jdk/rev/d64b14c25c82 6636363: BufferUnderflowException decoding length 6 UTF-8 sequences with direct buffers Reviewed-by: sherman ! src/share/classes/sun/nio/cs/UTF_8.java Changeset: 3e7a4b6ef105 Author: martin Date: 2008-05-10 11:49 -0700 URL: http://hg.openjdk.java.net/jdk7/jsn/jdk/rev/3e7a4b6ef105 6691185: (coll) TreeMap.navigableKeySet's descendingIterator method starts at first instead of last entry Reviewed-by: dl, chegar ! src/share/classes/java/util/TreeMap.java ! test/java/util/Collection/MOAT.java ! test/java/util/NavigableMap/LockStep.java Changeset: 9781e5c7b9ba Author: martin Date: 2008-05-10 12:14 -0700 URL: http://hg.openjdk.java.net/jdk7/jsn/jdk/rev/9781e5c7b9ba 6691215: (coll) IdentityHashMap.containsValue(null) returns true when null value not present Reviewed-by: dl, chegar, alanb Contributed-by: scottb at google.com ! src/share/classes/java/util/IdentityHashMap.java ! test/java/util/Collection/MOAT.java Changeset: 61a7e1919ba3 Author: wetmore Date: 2008-05-11 00:26 -0700 URL: http://hg.openjdk.java.net/jdk7/jsn/jdk/rev/61a7e1919ba3 Merge From christopher.hegarty at sun.com Thu May 15 02:28:17 2008 From: christopher.hegarty at sun.com (christopher.hegarty at sun.com) Date: Thu, 15 May 2008 09:28:17 +0000 Subject: hg: jdk7/jsn/jdk: 6670408: testcase panics 1.5.0_12&_14 JVM when java.net.PlainSocketImpl trying to throw an exception Message-ID: <20080515092830.1499F28131@hg.openjdk.java.net> Changeset: ca48d7cc3579 Author: chegar Date: 2008-05-15 10:26 +0100 URL: http://hg.openjdk.java.net/jdk7/jsn/jdk/rev/ca48d7cc3579 6670408: testcase panics 1.5.0_12&_14 JVM when java.net.PlainSocketImpl trying to throw an exception Summary: Replace select with poll Reviewed-by: alanb, jccollet ! src/solaris/native/java/net/PlainSocketImpl.c From bradford.wetmore at sun.com Mon May 19 11:14:01 2008 From: bradford.wetmore at sun.com (bradford.wetmore at sun.com) Date: Mon, 19 May 2008 18:14:01 +0000 Subject: hg: jdk7/jsn: 3 new changesets Message-ID: <20080519181401.4829228279@hg.openjdk.java.net> Changeset: 613dea62de17 Author: xdono Date: 2008-04-24 12:12 -0700 URL: http://hg.openjdk.java.net/jdk7/jsn/rev/613dea62de17 Added tag jdk7-b26 for changeset 9410f77cc30c ! .hgtags Changeset: 0f440f3321f5 Author: ohair Date: 2008-04-30 19:35 -0700 URL: http://hg.openjdk.java.net/jdk7/jsn/rev/0f440f3321f5 6563616: Clarify instructions for unpacking openjdk binary "plug" 6611685: Incorrect link to CA certs info from build README 6682167: Add cygwin faq to README-builds.html Reviewed-by: xdono ! README-builds.html Changeset: 11b4dc9f2be3 Author: xdono Date: 2008-05-13 11:31 -0700 URL: http://hg.openjdk.java.net/jdk7/jsn/rev/11b4dc9f2be3 Merge From bradford.wetmore at sun.com Mon May 19 11:14:46 2008 From: bradford.wetmore at sun.com (bradford.wetmore at sun.com) Date: Mon, 19 May 2008 18:14:46 +0000 Subject: hg: jdk7/jsn/corba: Added tag jdk7-b26 for changeset 0043eb3d4e62 Message-ID: <20080519181447.BDEBA2827E@hg.openjdk.java.net> Changeset: e84e9018bebb Author: xdono Date: 2008-04-24 12:12 -0700 URL: http://hg.openjdk.java.net/jdk7/jsn/corba/rev/e84e9018bebb Added tag jdk7-b26 for changeset 0043eb3d4e62 ! .hgtags From bradford.wetmore at sun.com Mon May 19 11:16:50 2008 From: bradford.wetmore at sun.com (bradford.wetmore at sun.com) Date: Mon, 19 May 2008 18:16:50 +0000 Subject: hg: jdk7/jsn/hotspot: 85 new changesets Message-ID: <20080519181949.345C028283@hg.openjdk.java.net> Changeset: 5ff61c9f5601 Author: jmasa Date: 2008-02-11 15:40 -0800 URL: http://hg.openjdk.java.net/jdk7/jsn/hotspot/rev/5ff61c9f5601 6624782: Bigapps crashes during CMS precleaning. Summary: Lowered optimization level for files instanceKlass.cpp and objArrayKlass.cpp Reviewed-by: ysr ! build/solaris/makefiles/amd64.make Changeset: f21b879b4c72 Author: ysr Date: 2008-02-12 16:07 -0800 URL: http://hg.openjdk.java.net/jdk7/jsn/hotspot/rev/f21b879b4c72 6659981: +ParallelRefProcEnabled crashes on single core platform Summary: Disable parallel reference processing when there are no worker threads Reviewed-by: apetrusenko, pbk, jmasa, tonyp ! src/share/vm/memory/referenceProcessor.cpp Changeset: 73e96e5c30df Author: jmasa Date: 2008-02-15 07:01 -0800 URL: http://hg.openjdk.java.net/jdk7/jsn/hotspot/rev/73e96e5c30df 6624765: Guarantee failure "Unexpected dirty card found" Summary: In verification take into account partial coverage of a region by a card and expansion of the card table. Reviewed-by: ysr, apetrusenko ! src/share/vm/gc_implementation/parNew/parNewGeneration.cpp ! src/share/vm/memory/cardTableModRefBS.cpp ! src/share/vm/memory/cardTableRS.cpp ! src/share/vm/memory/cardTableRS.hpp ! src/share/vm/memory/genRemSet.hpp ! src/share/vm/memory/tenuredGeneration.cpp Changeset: 2faf283ce688 Author: ysr Date: 2008-02-16 22:41 -0800 URL: http://hg.openjdk.java.net/jdk7/jsn/hotspot/rev/2faf283ce688 6621144: CMS: assertion failure "is_cms_thread == Thread::current()->is_ConcurrentGC_thread()" Summary: Take lock conditionally (in asynchronous mode only) when updating the dead-object map. Reviewed-by: jmasa ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp Changeset: 762905818571 Author: jmasa Date: 2008-02-20 08:40 -0800 URL: http://hg.openjdk.java.net/jdk7/jsn/hotspot/rev/762905818571 6665445: Backout change to CardTableModRefBS::resize_covered_region() Summary: Backed out part of cahnge for 6624765 because of nightly testing regressions. Reviewers below were for 6624765. Reviewed-by: ysr, apetrusenko ! src/share/vm/memory/cardTableModRefBS.cpp Changeset: 173195ff483a Author: ysr Date: 2008-02-21 11:03 -0800 URL: http://hg.openjdk.java.net/jdk7/jsn/hotspot/rev/173195ff483a 6642634: Test nsk/regression/b6186200 crashed with SIGSEGV Summary: Use correct allocation path in expand_and_allocate() so object's mark and p-bits are set as appropriate. Reviewed-by: jmasa, pbk ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp Changeset: 28372612af5e Author: jmasa Date: 2008-02-22 17:17 -0800 URL: http://hg.openjdk.java.net/jdk7/jsn/hotspot/rev/28372612af5e 6362677: Change parallel GC collector default number of parallel GC threads. Summary: Use the same default number of GC threads as used by ParNewGC and ConcMarkSweepGC (i.e., the 5/8th rule). Reviewed-by: ysr, tonyp ! src/cpu/sparc/vm/vm_version_sparc.cpp ! src/cpu/sparc/vm/vm_version_sparc.hpp ! src/share/vm/gc_implementation/parallelScavenge/generationSizer.hpp ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/arguments.hpp ! src/share/vm/runtime/globals.hpp ! src/share/vm/runtime/vm_version.cpp ! src/share/vm/runtime/vm_version.hpp Changeset: 3c1dbcaaab1d Author: ysr Date: 2008-02-26 15:57 -0800 URL: http://hg.openjdk.java.net/jdk7/jsn/hotspot/rev/3c1dbcaaab1d 6621728: Heap inspection should not crash in the face of C-heap exhaustion Summary: Deal more gracefully with situations where C-heap scratch space cannot be had Reviewed-by: jmasa ! src/share/vm/memory/heapInspection.cpp ! src/share/vm/memory/heapInspection.hpp Changeset: 6432c3bb6240 Author: ysr Date: 2008-02-29 14:42 -0800 URL: http://hg.openjdk.java.net/jdk7/jsn/hotspot/rev/6432c3bb6240 6668743: CMS: Consolidate block statistics reporting code Summary: Reduce the amount of related code replication and improve pretty printing. Reviewed-by: jmasa ! src/share/vm/gc_implementation/concurrentMarkSweep/binaryTreeDictionary.cpp ! src/share/vm/gc_implementation/concurrentMarkSweep/compactibleFreeListSpace.cpp ! src/share/vm/gc_implementation/concurrentMarkSweep/compactibleFreeListSpace.hpp ! src/share/vm/gc_implementation/concurrentMarkSweep/freeList.cpp ! src/share/vm/gc_implementation/concurrentMarkSweep/freeList.hpp ! src/share/vm/gc_implementation/includeDB_gc_shared + src/share/vm/gc_implementation/shared/allocationStats.cpp + src/share/vm/gc_implementation/shared/allocationStats.hpp ! src/share/vm/includeDB_core - src/share/vm/memory/allocationStats.cpp - src/share/vm/memory/allocationStats.hpp Changeset: 183f41cf8bfe Author: jmasa Date: 2008-03-02 16:10 -0800 URL: http://hg.openjdk.java.net/jdk7/jsn/hotspot/rev/183f41cf8bfe 6557851: CMS: ergonomics defaults are not set with FLAG_SET_ERGO Summary: Default values set by cms ergonomics are set with FLAG_SET_DEFAULT so down stream the values look like the default values and affect how later parameters are set. Set these values with FLAG_SET_ERGO instead and adjust how later parameters are interpreted. Reviewed-by: iveresov, apetrusenko, pbk, ysr ! src/share/vm/gc_implementation/parNew/asParNewGeneration.cpp ! src/share/vm/gc_implementation/parallelScavenge/asPSYoungGen.cpp ! src/share/vm/gc_implementation/parallelScavenge/parallelScavengeHeap.cpp ! src/share/vm/gc_implementation/parallelScavenge/parallelScavengeHeap.hpp ! src/share/vm/gc_implementation/parallelScavenge/psYoungGen.cpp ! src/share/vm/memory/collectorPolicy.cpp ! src/share/vm/memory/collectorPolicy.hpp ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/globals.cpp ! src/share/vm/runtime/globals_extension.hpp Changeset: 6228104986ca Author: jcoomes Date: 2008-03-05 17:37 -0800 URL: http://hg.openjdk.java.net/jdk7/jsn/hotspot/rev/6228104986ca Merge - src/share/vm/memory/allocationStats.cpp - src/share/vm/memory/allocationStats.hpp Changeset: d825a8a2bd39 Author: jmasa Date: 2008-03-11 14:19 -0700 URL: http://hg.openjdk.java.net/jdk7/jsn/hotspot/rev/d825a8a2bd39 6673975: Disable ZapUnusedHeapArea to reduce GC execution times of debug JVM's. Summary: Mangling the unused space is having an adverse affect on testing with fastdebug builds so turn it off by default. Reviewed-by: ysr, tonyp ! src/share/vm/runtime/globals.hpp Changeset: f8236e79048a Author: dcubed Date: 2007-12-05 09:00 -0800 URL: http://hg.openjdk.java.net/jdk7/jsn/hotspot/rev/f8236e79048a 6664627: Merge changes made only in hotspot 11 forward to jdk 7 Reviewed-by: jcoomes ! src/cpu/sparc/vm/stubGenerator_sparc.cpp ! src/cpu/sparc/vm/vtableStubs_sparc.cpp ! src/cpu/x86/vm/stubGenerator_x86_32.cpp ! src/cpu/x86/vm/stubGenerator_x86_64.cpp ! src/cpu/x86/vm/vtableStubs_x86_32.cpp ! src/cpu/x86/vm/vtableStubs_x86_64.cpp ! src/share/vm/oops/klassVtable.cpp ! src/share/vm/oops/klassVtable.hpp ! src/share/vm/runtime/sharedRuntime.cpp ! src/share/vm/runtime/sharedRuntime.hpp ! src/share/vm/runtime/stubRoutines.cpp ! src/share/vm/runtime/stubRoutines.hpp Changeset: ff5961f4c095 Author: never Date: 2007-12-05 09:01 -0800 URL: http://hg.openjdk.java.net/jdk7/jsn/hotspot/rev/ff5961f4c095 6395208: Elide autoboxing for calls to HashMap.get(int) and HashMap.get(long) Reviewed-by: kvn, rasbold + src/share/vm/ci/ciObjArray.cpp ! src/share/vm/ci/ciObjArray.hpp ! src/share/vm/classfile/vmSymbols.hpp ! src/share/vm/includeDB_core ! src/share/vm/opto/addnode.cpp ! src/share/vm/opto/addnode.hpp ! src/share/vm/opto/c2_globals.hpp ! src/share/vm/opto/cfgnode.hpp ! src/share/vm/opto/ifnode.cpp ! src/share/vm/opto/loopnode.cpp ! src/share/vm/opto/loopnode.hpp ! src/share/vm/opto/memnode.cpp ! src/share/vm/opto/memnode.hpp ! src/share/vm/opto/parse2.cpp ! src/share/vm/opto/type.hpp ! src/share/vm/runtime/arguments.cpp Changeset: c7d713375c94 Author: phh Date: 2007-12-05 09:02 -0800 URL: http://hg.openjdk.java.net/jdk7/jsn/hotspot/rev/c7d713375c94 6621621: HashMap front cache should be enabled only with AggressiveOpts Reviewed-by: sbohne, xlu ! src/share/vm/classfile/vmSymbols.hpp ! src/share/vm/runtime/thread.cpp Changeset: a73cc31728fe Author: rasbold Date: 2007-12-05 09:03 -0800 URL: http://hg.openjdk.java.net/jdk7/jsn/hotspot/rev/a73cc31728fe 6614036: REGRESSION: Java server x86 VM intermittently crash with SIGSEGV (0xb) Summary: restore destination address in x86 32-bit checkcast_arraycopy stub Reviewed-by: jrose, kvn, never ! src/cpu/x86/vm/stubGenerator_x86_32.cpp Changeset: e195fe4c40c7 Author: phh Date: 2007-12-05 09:04 -0800 URL: http://hg.openjdk.java.net/jdk7/jsn/hotspot/rev/e195fe4c40c7 6629887: 64-bit windows should not restrict default heap size to 1400m Reviewed-by: jmasa, sbohne, ikrylov, xlu ! src/os/linux/vm/os_linux.cpp ! src/os/windows/vm/os_windows.cpp ! src/os_cpu/linux_x86/vm/os_linux_x86.cpp Changeset: b611e572fc5b Author: jcoomes Date: 2007-12-06 13:59 -0800 URL: http://hg.openjdk.java.net/jdk7/jsn/hotspot/rev/b611e572fc5b 6635560: segv in reference processor on t1000 Summary: Revert back to using the default page size for the card table Reviewed-by: pbk, phh ! src/share/vm/memory/cardTableModRefBS.cpp Changeset: 90f5ddc7297b Author: coleenp Date: 2008-01-17 13:38 -0800 URL: http://hg.openjdk.java.net/jdk7/jsn/hotspot/rev/90f5ddc7297b 6646946: Kernel installation failed on Japanese and Chinese XP SP2 (VM part) Summary: convert strings from Download Manager into native encoding in the VM Reviewed-by: sbohne, never, phh, kamg, xlu ! src/share/vm/classfile/javaClasses.cpp ! src/share/vm/classfile/javaClasses.hpp ! src/share/vm/classfile/systemDictionary.cpp Changeset: 9bdad1bb1c31 Author: kvn Date: 2008-02-12 18:37 -0800 URL: http://hg.openjdk.java.net/jdk7/jsn/hotspot/rev/9bdad1bb1c31 6621098: "* HeapWordSize" for TrackedInitializationLimit is missing Summary: '* HeapWordSize' is missing in GraphKit::set_output_for_allocation() Reviewed-by: rasbold, jrose, never ! src/share/vm/opto/graphKit.cpp Changeset: 953939ef62ab Author: kvn Date: 2008-02-20 16:19 -0800 URL: http://hg.openjdk.java.net/jdk7/jsn/hotspot/rev/953939ef62ab 6614330: Node::dump(n) does not print full graph for specified depth. Summary: A node is not processed in dump_nodes() if it was visited during processing previous inputs. Reviewed-by: rasbold ! src/share/vm/opto/node.cpp Changeset: c5cbd367e4d1 Author: kvn Date: 2008-02-20 17:23 -0800 URL: http://hg.openjdk.java.net/jdk7/jsn/hotspot/rev/c5cbd367e4d1 6621094: PrintOptoAssembly is broken for oops information in DebugInfo Summary: OopMapValue and VMRegImpl classes miss the virtual method print_on(st). Reviewed-by: rasbold, jrose, never ! src/share/vm/code/vmreg.cpp ! src/share/vm/code/vmreg.hpp ! src/share/vm/compiler/oopMap.cpp ! src/share/vm/compiler/oopMap.hpp Changeset: 0871d5cd64cd Author: kvn Date: 2008-02-21 14:03 -0800 URL: http://hg.openjdk.java.net/jdk7/jsn/hotspot/rev/0871d5cd64cd 6621084: ciMethodBlocks::split_block_at() is broken for methods with exception handler Summary: After an exception handler block is split the exception information is not moved to the new block which starts in exception handler BCI. Reviewed-by: jrose ! src/share/vm/ci/ciMethodBlocks.cpp ! src/share/vm/ci/ciMethodBlocks.hpp Changeset: 1f530c629c7d Author: kvn Date: 2008-02-21 19:03 -0800 URL: http://hg.openjdk.java.net/jdk7/jsn/hotspot/rev/1f530c629c7d 6498878: client compiler crashes on windows when dealing with breakpoint instructions Summary: _is_compilable check prevents breakpoint bytecodes reversion when loading bytecodes for ciMethod. Reviewed-by: never ! src/share/vm/ci/ciMethod.cpp Changeset: 67914967a4b5 Author: kvn Date: 2008-02-22 17:55 -0800 URL: http://hg.openjdk.java.net/jdk7/jsn/hotspot/rev/67914967a4b5 6650373: Assert in methodOopDesc::make_adapters() Summary: AdapterHandlerLibrary::get_create_adapter_index() returns incorrect value (-2) when CodeCache is full. Reviewed-by: sgoldman ! src/share/vm/opto/output.cpp ! src/share/vm/runtime/sharedRuntime.cpp Changeset: d5fc211aea19 Author: kvn Date: 2008-02-25 15:05 -0800 URL: http://hg.openjdk.java.net/jdk7/jsn/hotspot/rev/d5fc211aea19 6633953: type2aelembytes{T_ADDRESS} should be 8 bytes in 64 bit VM Summary: T_ADDRESS size is defined as 'int' size (4 bytes) but C2 use it for raw pointers and as memory type for StoreP and LoadP nodes. Reviewed-by: jrose ! src/cpu/sparc/vm/c1_LIRAssembler_sparc.cpp ! src/cpu/sparc/vm/c1_LIRGenerator_sparc.cpp ! src/cpu/x86/vm/c1_LIRAssembler_x86.cpp ! src/cpu/x86/vm/c1_LIRGenerator_x86.cpp ! src/share/vm/c1/c1_LIR.cpp ! src/share/vm/ci/ciField.hpp ! src/share/vm/oops/arrayOop.hpp ! src/share/vm/oops/klass.cpp ! src/share/vm/opto/graphKit.cpp ! src/share/vm/opto/library_call.cpp ! src/share/vm/opto/memnode.cpp ! src/share/vm/opto/memnode.hpp ! src/share/vm/opto/superword.cpp ! src/share/vm/opto/vectornode.cpp ! src/share/vm/opto/vectornode.hpp ! src/share/vm/services/heapDumper.cpp ! src/share/vm/utilities/globalDefinitions.cpp ! src/share/vm/utilities/globalDefinitions.hpp Changeset: 65a06b4a51b8 Author: jrose Date: 2008-02-27 00:23 -0800 URL: http://hg.openjdk.java.net/jdk7/jsn/hotspot/rev/65a06b4a51b8 6610906: inexplicable IncompatibleClassChangeError Summary: dependency check must treat polymorphic interfaces consistently Reviewed-by: kvn, never, sgoldman ! src/share/vm/code/dependencies.cpp ! src/share/vm/code/nmethod.cpp Changeset: 6152cbb08ce9 Author: kvn Date: 2008-02-28 10:45 -0800 URL: http://hg.openjdk.java.net/jdk7/jsn/hotspot/rev/6152cbb08ce9 6590177: jck60019 test assert(!repeated,"do not walk merges twice") Summary: A mergemem node could be not in worklist_store but in should_not_repeat vectorset since it was processed and removed from worklist_store before. Reviewed-by: jrose, never ! src/share/vm/opto/gcm.cpp Changeset: 4d428c5b4cb3 Author: kvn Date: 2008-02-28 15:40 -0800 URL: http://hg.openjdk.java.net/jdk7/jsn/hotspot/rev/4d428c5b4cb3 6667573: Use set_req_X() in AddPNode::Ideal() for Iterative GVN Summary: set_req_X() puts dependent nodes on IGVN worklist which allows to improve graph and gives more opportunities for EA scalar replacement. Reviewed-by: jrose, never ! src/share/vm/opto/addnode.cpp Changeset: 3288958bf319 Author: kvn Date: 2008-02-29 09:57 -0800 URL: http://hg.openjdk.java.net/jdk7/jsn/hotspot/rev/3288958bf319 6667580: Optimize CmpP for allocations Summary: CmpP could be optimized out if it compares new allocated objects. Reviewed-by: jrose, never, rasbold ! src/share/vm/includeDB_compiler2 ! src/share/vm/opto/callnode.hpp ! src/share/vm/opto/memnode.hpp ! src/share/vm/opto/node.hpp ! src/share/vm/opto/subnode.cpp Changeset: 545c277a3ecf Author: kvn Date: 2008-02-29 11:22 -0800 URL: http://hg.openjdk.java.net/jdk7/jsn/hotspot/rev/545c277a3ecf 6667581: Don't generate initialization (by 0) code for arrays with size 0 Summary: generate_arraycopy() does not check the size of allocated array. Reviewed-by: jrose, never ! src/share/vm/opto/library_call.cpp Changeset: e2ae28d2ce91 Author: kvn Date: 2008-02-29 19:07 -0800 URL: http://hg.openjdk.java.net/jdk7/jsn/hotspot/rev/e2ae28d2ce91 6667588: Don't generate duplicated CMP for float/double values Summary: float CMove generation add duplicated CMPF if there are more then one Move depending on the condition. Reviewed-by: jrose, never, rasbold ! src/share/vm/opto/loopopts.cpp Changeset: f34d9da7acb2 Author: kvn Date: 2008-02-29 19:57 -0800 URL: http://hg.openjdk.java.net/jdk7/jsn/hotspot/rev/f34d9da7acb2 6667618: disable LoadL->ConvL2I ==> LoadI optimization Summary: this optimization causes problems (sizes of Load and Store nodes do not match) for objects initialization code and Escape Analysis Reviewed-by: jrose, never ! src/share/vm/opto/connode.cpp ! src/share/vm/opto/memnode.cpp Changeset: 73970d8c0b27 Author: kvn Date: 2008-03-05 11:33 -0800 URL: http://hg.openjdk.java.net/jdk7/jsn/hotspot/rev/73970d8c0b27 6671250: In Parse::do_if() old Cmp node 'c' should be replaced with new one after BoolNode transformation Summary: In Parse::do_if() 'c' (CmpNode) node may be changed during BoolNode transformation so 'c' may became dead but the node is referenced later in the code. Reviewed-by: never ! src/share/vm/opto/parse2.cpp Changeset: b789bcaf2dd9 Author: kvn Date: 2008-03-06 10:30 -0800 URL: http://hg.openjdk.java.net/jdk7/jsn/hotspot/rev/b789bcaf2dd9 6667610: (Escape Analysis) retry compilation without EA if it fails Summary: During split unique types EA could exceed nodes limit and fail the method compilation. Reviewed-by: rasbold ! src/share/vm/includeDB_compiler2 ! src/share/vm/opto/c2compiler.cpp ! src/share/vm/opto/c2compiler.hpp ! src/share/vm/opto/compile.cpp ! src/share/vm/opto/compile.hpp ! src/share/vm/opto/escape.cpp ! src/share/vm/opto/parse1.cpp Changeset: 76256d272075 Author: kvn Date: 2008-03-06 10:53 -0800 URL: http://hg.openjdk.java.net/jdk7/jsn/hotspot/rev/76256d272075 6667612: (Escape Analysis) disable loop cloning if it has a scalar replaceable allocation Summary: Cloning an allocation will not allow scalar replacement since memory operations could not be associated with one allocation. Reviewed-by: rasbold ! src/share/vm/opto/callnode.cpp ! src/share/vm/opto/callnode.hpp ! src/share/vm/opto/escape.cpp ! src/share/vm/opto/loopTransform.cpp ! src/share/vm/opto/loopnode.cpp ! src/share/vm/opto/loopnode.hpp Changeset: 7c1f32ae4a20 Author: kvn Date: 2008-03-06 20:58 -0800 URL: http://hg.openjdk.java.net/jdk7/jsn/hotspot/rev/7c1f32ae4a20 6670459: Fix Node::dump() performance Summary: dump full ideal graph takes forever. Reviewed-by: never, rasbold ! src/share/vm/opto/node.cpp ! src/share/vm/opto/node.hpp Changeset: 874b2c4f43d1 Author: kvn Date: 2008-03-07 11:09 -0800 URL: http://hg.openjdk.java.net/jdk7/jsn/hotspot/rev/874b2c4f43d1 6667605: (Escape Analysis) inline java constructors when EA is on Summary: java constructors should be inlined to be able scalar replace a new object Reviewed-by: rasbold ! src/share/vm/opto/bytecodeInfo.cpp ! src/share/vm/opto/parse.hpp ! src/share/vm/opto/phaseX.cpp Changeset: 1216832af221 Author: jcoomes Date: 2008-03-10 17:21 -0700 URL: http://hg.openjdk.java.net/jdk7/jsn/hotspot/rev/1216832af221 Merge Changeset: d821d920b465 Author: kvn Date: 2008-03-11 11:04 -0700 URL: http://hg.openjdk.java.net/jdk7/jsn/hotspot/rev/d821d920b465 6623167: C2 crashed in StoreCMNode::Value Summary: C2 crashed in StoreCMNode::Value because n->in(MemNode::OopStore) is 0. Reviewed-by: rasbold, never ! src/share/vm/opto/memnode.cpp Changeset: 52fed2ec0afb Author: kvn Date: 2008-03-11 11:25 -0700 URL: http://hg.openjdk.java.net/jdk7/jsn/hotspot/rev/52fed2ec0afb 6667620: (Escape Analysis) fix deoptimization for scalar replaced objects Summary: Deoptimization code for reallocation and relocking scalar replaced objects has to be fixed. Reviewed-by: rasbold, never ! src/share/vm/ci/ciInstanceKlass.cpp ! src/share/vm/ci/ciInstanceKlass.hpp ! src/share/vm/code/debugInfo.cpp ! src/share/vm/code/scopeDesc.cpp ! src/share/vm/oops/instanceKlass.cpp ! src/share/vm/runtime/deoptimization.cpp Changeset: 48a3fa21394b Author: kvn Date: 2008-03-11 19:00 -0700 URL: http://hg.openjdk.java.net/jdk7/jsn/hotspot/rev/48a3fa21394b 6667615: (Escape Analysis) extend MDO to cache arguments escape state Summary: Use MDO to cache arguments escape state determined by the byte code escape analyzer. Reviewed-by: never ! src/share/vm/ci/bcEscapeAnalyzer.cpp ! src/share/vm/ci/bcEscapeAnalyzer.hpp ! src/share/vm/ci/ciMethodData.cpp ! src/share/vm/ci/ciMethodData.hpp ! src/share/vm/classfile/vmSymbols.cpp ! src/share/vm/classfile/vmSymbols.hpp ! src/share/vm/oops/methodDataOop.cpp ! src/share/vm/oops/methodDataOop.hpp Changeset: 8b6e49187640 Author: rasbold Date: 2008-03-13 05:40 -0700 URL: http://hg.openjdk.java.net/jdk7/jsn/hotspot/rev/8b6e49187640 Merge ! src/share/vm/includeDB_core ! src/share/vm/memory/cardTableModRefBS.cpp ! src/share/vm/runtime/arguments.cpp Changeset: 2c106685d6d0 Author: dcubed Date: 2008-03-12 18:06 -0700 URL: http://hg.openjdk.java.net/jdk7/jsn/hotspot/rev/2c106685d6d0 6497639: 4/3 Profiling Swing application caused JVM crash Summary: Make RedefineClasses() interoperate better with class sharing. Reviewed-by: sspitsyn, jmasa ! src/share/vm/classfile/dictionary.cpp ! src/share/vm/memory/compactingPermGenGen.cpp ! src/share/vm/oops/instanceKlass.cpp ! src/share/vm/oops/instanceKlass.hpp Changeset: d8b3ef7ee3e5 Author: dcubed Date: 2008-03-12 18:07 -0700 URL: http://hg.openjdk.java.net/jdk7/jsn/hotspot/rev/d8b3ef7ee3e5 6599425: 4/3 OopMapCache::lookup() can cause later crash or assert() failure Summary: Add should_not_be_cached() to markOop and methodOop and query that status inOopMapCache::lookup() Reviewed-by: coleenp, sspitsyn, jmasa ! src/share/vm/includeDB_core ! src/share/vm/interpreter/oopMapCache.cpp ! src/share/vm/oops/markOop.cpp ! src/share/vm/oops/markOop.hpp ! src/share/vm/oops/methodOop.cpp ! src/share/vm/oops/methodOop.hpp ! src/share/vm/prims/jvmtiRedefineClassesTrace.hpp Changeset: 31000d79ec71 Author: dcubed Date: 2008-03-12 18:09 -0700 URL: http://hg.openjdk.java.net/jdk7/jsn/hotspot/rev/31000d79ec71 6453355: 4/4 new No_Safepoint_Verifier uses fail during GC Summary: (for Serguei) Clean up use of No_Safepoint_Verifier in JVM TI Reviewed-by: dcubed ! src/share/vm/oops/instanceKlass.cpp ! src/share/vm/oops/instanceKlass.hpp ! src/share/vm/runtime/thread.cpp Changeset: 485d403e94e1 Author: dcubed Date: 2008-03-12 18:37 -0700 URL: http://hg.openjdk.java.net/jdk7/jsn/hotspot/rev/485d403e94e1 6452081: 3/4 Allow for Linux builds with Sun Studio Linux compilers Summary: (for Serguei) Allow for Linux builds with Sun Studio Linux compilers Reviewed-by: sspitsyn, ohair ! agent/src/os/linux/ps_core.c ! agent/src/os/linux/ps_proc.c ! build/linux/Makefile ! build/linux/makefiles/amd64.make ! build/linux/makefiles/buildtree.make + build/linux/makefiles/sparcWorks.make + build/linux/platform_amd64.suncc + build/linux/platform_i486.suncc ! src/cpu/x86/vm/assembler_x86_64.cpp ! src/os/linux/vm/attachListener_linux.cpp ! src/os_cpu/linux_x86/vm/bytes_linux_x86.inline.hpp ! src/os_cpu/linux_x86/vm/os_linux_x86.cpp ! src/share/vm/utilities/globalDefinitions_sparcWorks.hpp Changeset: 1ffa5cdd0b7e Author: dcubed Date: 2008-03-12 18:39 -0700 URL: http://hg.openjdk.java.net/jdk7/jsn/hotspot/rev/1ffa5cdd0b7e 6667089: 3/3 multiple redefinitions of a class break reflection Summary: Use instanceKlass::method_with_idnum() instead of slot() to work with RedefineClasses(). Reviewed-by: sspitsyn ! src/share/vm/runtime/reflection.cpp Changeset: 75b0f3cb1943 Author: dcubed Date: 2008-03-13 14:17 -0700 URL: http://hg.openjdk.java.net/jdk7/jsn/hotspot/rev/75b0f3cb1943 Merge ! src/os_cpu/linux_x86/vm/os_linux_x86.cpp ! src/share/vm/includeDB_core ! src/share/vm/oops/instanceKlass.cpp ! src/share/vm/runtime/thread.cpp Changeset: 9785f6d2dd97 Author: kamg Date: 2008-01-31 09:41 -0500 URL: http://hg.openjdk.java.net/jdk7/jsn/hotspot/rev/9785f6d2dd97 6631248: Memory problem when doing invalid type cast Summary: Changed memory allocation method for exception method Reviewed-by: ysr, never ! src/share/vm/runtime/sharedRuntime.cpp Changeset: d4a0f561287a Author: sbohne Date: 2008-01-31 14:56 -0500 URL: http://hg.openjdk.java.net/jdk7/jsn/hotspot/rev/d4a0f561287a 6598190: JPRT tests fail when run with -XX:+CheckUnhandledOops Summary: Work around Sun Studio C++ compiler bug 6629277 in dependencies.cpp Reviewed-by: kamg, sgoldman, pbk ! src/share/vm/code/dependencies.cpp Changeset: 2a8eb116ebbe Author: xlu Date: 2008-02-05 23:21 -0800 URL: http://hg.openjdk.java.net/jdk7/jsn/hotspot/rev/2a8eb116ebbe 6610420: Debug VM crashes during monitor lock rank checking Summary: Make SerializePage lock as raw lock and add name for mutex locks Reviewed-by: never, dice, dholmes ! src/share/vm/runtime/mutex.cpp ! src/share/vm/runtime/mutex.hpp ! src/share/vm/runtime/mutexLocker.cpp ! src/share/vm/runtime/mutexLocker.hpp ! src/share/vm/runtime/os.cpp Changeset: 31d829b33f26 Author: coleenp Date: 2008-02-27 13:55 -0500 URL: http://hg.openjdk.java.net/jdk7/jsn/hotspot/rev/31d829b33f26 6549844: Wording problems in "An unexpected error ..." Summary: Changed wording to "A fatal error.." also don't claim it's not VM bug if in hotspot compilers (Java thread in native). Reviewed-by: jjh, sbohne, jrose, never ! src/share/vm/utilities/vmError.cpp Changeset: ff0979201b06 Author: sbohne Date: 2008-03-03 14:47 -0500 URL: http://hg.openjdk.java.net/jdk7/jsn/hotspot/rev/ff0979201b06 6655385: Disable frame pointer omission in jvm.dll on Windows for better crash logs Summary: Add /Oy- C++ compiler option on Windows Reviewed-by: phh, never, ysr ! build/windows/makefiles/compile.make Changeset: 7ee622712fcf Author: sbohne Date: 2008-03-04 09:44 -0500 URL: http://hg.openjdk.java.net/jdk7/jsn/hotspot/rev/7ee622712fcf 6666698: EnableBiasedLocking with BiasedLockingStartupDelay can block Watcher thread Summary: Enqueue VM_EnableBiasedLocking operation asynchronously Reviewed-by: never, xlu, kbr, acorn ! src/share/vm/runtime/biasedLocking.cpp Changeset: 887682771f69 Author: jcoomes Date: 2008-03-12 16:31 -0700 URL: http://hg.openjdk.java.net/jdk7/jsn/hotspot/rev/887682771f69 Merge Changeset: 8d84e28e68ba Author: sbohne Date: 2008-03-14 10:43 -0400 URL: http://hg.openjdk.java.net/jdk7/jsn/hotspot/rev/8d84e28e68ba 6204603: Modify hotspot to use new Solaris mmap semantics for class data archive file Summary: os::attempt_reserve_memory_at() now passes an address hint to mmap Reviewed-by: kamg, dice ! src/os/solaris/vm/os_solaris.cpp ! src/os/solaris/vm/os_solaris.hpp Changeset: 5a76ab815e34 Author: sbohne Date: 2008-03-19 09:58 -0400 URL: http://hg.openjdk.java.net/jdk7/jsn/hotspot/rev/5a76ab815e34 6667833: Remove CacheTimeMillis Summary: Remove -XX:+CacheTimeMillis option and associated functionality Reviewed-by: acorn, never ! src/os/linux/vm/os_linux.cpp ! src/os/solaris/vm/os_solaris.cpp ! src/os/windows/vm/os_windows.cpp ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/globals.hpp ! src/share/vm/runtime/java.cpp ! src/share/vm/runtime/os.cpp ! src/share/vm/runtime/os.hpp ! src/share/vm/runtime/task.cpp ! src/share/vm/runtime/task.hpp ! src/share/vm/runtime/thread.cpp Changeset: cd0742ba123c Author: kamg Date: 2008-03-20 09:17 -0500 URL: http://hg.openjdk.java.net/jdk7/jsn/hotspot/rev/cd0742ba123c Merge ! src/os/linux/vm/os_linux.cpp ! src/os/windows/vm/os_windows.cpp ! src/share/vm/code/dependencies.cpp ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/globals.hpp ! src/share/vm/runtime/sharedRuntime.cpp ! src/share/vm/runtime/thread.cpp Changeset: eac007780a58 Author: kvn Date: 2008-03-13 16:06 -0700 URL: http://hg.openjdk.java.net/jdk7/jsn/hotspot/rev/eac007780a58 6671807: (Escape Analysis) Add new ideal node to represent the state of a scalarized object at a safepoint Summary: Values of non-static fields of a scalarized object should be saved in debug info to reallocate the object during deoptimization. Reviewed-by: never ! src/share/vm/opto/callnode.cpp ! src/share/vm/opto/callnode.hpp ! src/share/vm/opto/classes.hpp ! src/share/vm/opto/compile.hpp ! src/share/vm/opto/graphKit.cpp ! src/share/vm/opto/macro.cpp ! src/share/vm/opto/matcher.cpp ! src/share/vm/opto/node.hpp ! src/share/vm/opto/output.cpp Changeset: b8f5ba577b02 Author: kvn Date: 2008-03-13 16:31 -0700 URL: http://hg.openjdk.java.net/jdk7/jsn/hotspot/rev/b8f5ba577b02 6673473: (Escape Analysis) Add the instance's field information to PhiNode Summary: Avoid an infinite generation of instance's field values Phi nodes. Reviewed-by: never ! src/share/vm/opto/cfgnode.hpp ! src/share/vm/opto/loopopts.cpp ! src/share/vm/opto/memnode.cpp ! src/share/vm/opto/memnode.hpp ! src/share/vm/opto/type.cpp ! src/share/vm/opto/type.hpp Changeset: 99269dbf4ba8 Author: kvn Date: 2008-03-14 15:26 -0700 URL: http://hg.openjdk.java.net/jdk7/jsn/hotspot/rev/99269dbf4ba8 6674588: (Escape Analysis) Improve Escape Analysis code Summary: Current EA code has several problems which have to be fixed. Reviewed-by: jrose, sgoldman ! src/share/vm/includeDB_compiler2 ! src/share/vm/opto/c2_globals.hpp ! src/share/vm/opto/callnode.cpp ! src/share/vm/opto/callnode.hpp ! src/share/vm/opto/compile.cpp ! src/share/vm/opto/compile.hpp ! src/share/vm/opto/escape.cpp ! src/share/vm/opto/escape.hpp ! src/share/vm/opto/node.cpp ! src/share/vm/opto/node.hpp ! src/share/vm/opto/phaseX.cpp ! src/share/vm/runtime/arguments.cpp Changeset: 6dbf1a175d6b Author: kvn Date: 2008-03-14 16:40 -0700 URL: http://hg.openjdk.java.net/jdk7/jsn/hotspot/rev/6dbf1a175d6b 6672848: (Escape Analysis) improve lock elimination with EA Summary: Remove lock/unlock MemBar nodes and specify locks in debug info for deoptimization. Reviewed-by: never ! src/share/vm/opto/callnode.cpp ! src/share/vm/opto/locknode.cpp ! src/share/vm/opto/locknode.hpp ! src/share/vm/opto/macro.cpp ! src/share/vm/opto/macro.hpp ! src/share/vm/opto/output.cpp Changeset: 16e1cb7cde24 Author: never Date: 2008-03-18 11:17 -0700 URL: http://hg.openjdk.java.net/jdk7/jsn/hotspot/rev/16e1cb7cde24 6666343: Compile::has_loops not always set correctly Summary: Compile::has_loops() should be set from inlined methods Reviewed-by: kvn, rasbold ! src/share/vm/opto/doCall.cpp Changeset: daf38130e60d Author: never Date: 2008-03-18 23:44 -0700 URL: http://hg.openjdk.java.net/jdk7/jsn/hotspot/rev/daf38130e60d 6676841: ClearArrayNode::Identity is incorrect for 64-bit Summary: ClearArrayNode::Identity should use TypeX instead of TypeInt Reviewed-by: jrose, kvn, sgoldman ! src/share/vm/opto/memnode.cpp Changeset: 8bb88f9877e5 Author: never Date: 2008-03-18 23:54 -0700 URL: http://hg.openjdk.java.net/jdk7/jsn/hotspot/rev/8bb88f9877e5 6659207: access violation in CompilerThread0 Summary: split_thru_phi produces top on a non-dead path Reviewed-by: kvn, rasbold, sgoldman ! src/share/vm/opto/loopopts.cpp + test/compiler/6659207/Test.java Changeset: b683f557224b Author: never Date: 2008-03-19 15:14 -0700 URL: http://hg.openjdk.java.net/jdk7/jsn/hotspot/rev/b683f557224b 6661247: Internal bug in 32-bit HotSpot optimizer while bit manipulations Summary: copy elimination of a constant value results in incorrect execution Reviewed-by: kvn, sgoldman, rasbold ! src/share/vm/opto/chaitin.hpp ! src/share/vm/opto/postaloc.cpp + test/compiler/6661247/Test.java Changeset: 3d62cb85208d Author: kvn Date: 2008-03-19 15:33 -0700 URL: http://hg.openjdk.java.net/jdk7/jsn/hotspot/rev/3d62cb85208d 6662967: Optimize I2D conversion on new x86 Summary: Use CVTDQ2PS and CVTDQ2PD for integer values conversions to float and double values on new AMD cpu. Reviewed-by: sgoldman, never ! src/cpu/x86/vm/assembler_x86_32.cpp ! src/cpu/x86/vm/assembler_x86_32.hpp ! src/cpu/x86/vm/assembler_x86_64.cpp ! src/cpu/x86/vm/assembler_x86_64.hpp ! src/cpu/x86/vm/vm_version_x86_32.cpp ! src/cpu/x86/vm/vm_version_x86_64.cpp ! src/cpu/x86/vm/x86_32.ad ! src/cpu/x86/vm/x86_64.ad ! src/share/vm/runtime/globals.hpp Changeset: f705f25597eb Author: never Date: 2008-03-20 10:43 -0700 URL: http://hg.openjdk.java.net/jdk7/jsn/hotspot/rev/f705f25597eb 6663621: JVM crashes while trying to execute api/java_security/Signature/SignatureTests.html#initSign tests. Summary: alignment expression with secondary induction variables is sometimes wrong Reviewed-by: kvn, rasbold ! src/share/vm/opto/superword.cpp + test/compiler/6663621/IVTest.java Changeset: a8880a78d355 Author: kvn Date: 2008-03-20 13:51 -0700 URL: http://hg.openjdk.java.net/jdk7/jsn/hotspot/rev/a8880a78d355 6259129: (Escape Analysis) scalar replacement for not escaping objects Summary: Use scalar replacement with EA to remove allocations for objects which do not escape the compiled method. Reviewed-by: rasbold, never, jrose ! src/share/vm/opto/macro.cpp ! src/share/vm/opto/macro.hpp ! src/share/vm/opto/phaseX.hpp Changeset: 2a9af0b9cb1c Author: kvn Date: 2008-03-20 15:11 -0700 URL: http://hg.openjdk.java.net/jdk7/jsn/hotspot/rev/2a9af0b9cb1c 6674600: (Escape Analysis) Optimize memory graph for instance's fields Summary: EA gives opportunite to do more aggressive memory optimizations. Reviewed-by: never, jrose ! src/share/vm/opto/callnode.cpp ! src/share/vm/opto/callnode.hpp ! src/share/vm/opto/cfgnode.cpp ! src/share/vm/opto/cfgnode.hpp ! src/share/vm/opto/graphKit.cpp ! src/share/vm/opto/memnode.cpp ! src/share/vm/opto/memnode.hpp Changeset: f68325221ce1 Author: kvn Date: 2008-03-21 00:49 -0700 URL: http://hg.openjdk.java.net/jdk7/jsn/hotspot/rev/f68325221ce1 6678377: Update build number for HS12 Summary: b01 -> b02 Reviewed-by: kvn ! make/hotspot_version Changeset: d6fe2e4959d6 Author: rasbold Date: 2008-03-21 08:32 -0700 URL: http://hg.openjdk.java.net/jdk7/jsn/hotspot/rev/d6fe2e4959d6 Merge ! src/cpu/x86/vm/assembler_x86_64.cpp ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/globals.hpp Changeset: 36cd3cc4d27b Author: kvn Date: 2008-03-27 09:12 -0700 URL: http://hg.openjdk.java.net/jdk7/jsn/hotspot/rev/36cd3cc4d27b 6679854: assert in escape.cpp:397 Summary: The assert misses the case CastX2P 'base' for an unsafe field reference Reviewed-by: never, jrose ! src/share/vm/opto/escape.cpp Changeset: e1e86702e43e Author: kvn Date: 2008-03-28 11:52 -0700 URL: http://hg.openjdk.java.net/jdk7/jsn/hotspot/rev/e1e86702e43e 6680665: bytecode Escape Analyzer produces incorrect escape information for methods without oop arguments Summary: bcEscapeAnalyzer does not analyze methods with no oop arguments. Reviewed-by: rasbold ! src/share/vm/ci/bcEscapeAnalyzer.cpp ! src/share/vm/ci/bcEscapeAnalyzer.hpp ! src/share/vm/oops/methodDataOop.hpp Changeset: 82db0859acbe Author: jcoomes Date: 2008-03-28 23:35 -0700 URL: http://hg.openjdk.java.net/jdk7/jsn/hotspot/rev/82db0859acbe 6642862: Code cache allocation fails with large pages after 6588638 Reviewed-by: apetrusenko ! src/os/linux/vm/os_linux.cpp ! src/os/solaris/vm/os_solaris.cpp ! src/os/windows/vm/os_windows.cpp ! src/share/vm/gc_implementation/parallelScavenge/parMarkBitMap.cpp ! src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.cpp ! src/share/vm/memory/heap.cpp ! src/share/vm/runtime/os.hpp Changeset: 092ea87cc974 Author: jcoomes Date: 2008-03-28 23:35 -0700 URL: http://hg.openjdk.java.net/jdk7/jsn/hotspot/rev/092ea87cc974 6679422: networkStream::connect() in ostream.cpp is not 64-bit clean Reviewed-by: jmasa, xlu ! src/share/vm/utilities/ostream.cpp Changeset: dee7a3f3dc9d Author: never Date: 2008-03-31 16:22 -0700 URL: http://hg.openjdk.java.net/jdk7/jsn/hotspot/rev/dee7a3f3dc9d 6636352: Unit tests for supplementary character support fail with -XX:+AggressiveOpts Summary: incorrect encoding Reviewed-by: kvn, rasbold, sgoldman, jrose ! src/cpu/sparc/vm/sparc.ad Changeset: de93acbb64fc Author: kvn Date: 2008-03-31 18:37 -0700 URL: http://hg.openjdk.java.net/jdk7/jsn/hotspot/rev/de93acbb64fc 6682236: C2 hits ideal nodes limit during IGVN optimization with EA Summary: missing check in LoadNode::Ideal() causes infinite generation of a value Phi. Reviewed-by: jrose, never ! src/share/vm/opto/memnode.cpp Changeset: d3cd40645d0d Author: kvn Date: 2008-04-01 16:14 -0700 URL: http://hg.openjdk.java.net/jdk7/jsn/hotspot/rev/d3cd40645d0d 6681646: Relocking of a scalar replaced object during deoptimization is broken Summary: Relocking of a thread-local object during deoptimization is broken Reviewed-by: kbr, jrose, never ! src/share/vm/runtime/deoptimization.cpp ! src/share/vm/runtime/deoptimization.hpp ! src/share/vm/runtime/vframe.cpp ! src/share/vm/runtime/vframe.hpp ! src/share/vm/runtime/vframe_hp.cpp Changeset: 6e085831cad7 Author: sbohne Date: 2008-04-10 15:49 -0400 URL: http://hg.openjdk.java.net/jdk7/jsn/hotspot/rev/6e085831cad7 6692235: Fix for 6666698 broke -XX:BiasedLockingStartupDelay=0 Summary: Stack allocated VM_EnableBiasedLocking op must be marked as such Reviewed-by: xlu, acorn, never, dholmes ! src/share/vm/runtime/biasedLocking.cpp Changeset: f3b3fe64f59f Author: kvn Date: 2008-04-15 10:49 -0700 URL: http://hg.openjdk.java.net/jdk7/jsn/hotspot/rev/f3b3fe64f59f 6692301: Side effect in NumberFormat tests with -server -Xcomp Summary: Optimization in CmpPNode::sub() removed the valid compare instruction because of false positive answer from detect_dominating_control(). Reviewed-by: jrose, sgoldman ! src/share/vm/opto/memnode.cpp ! src/share/vm/opto/memnode.hpp ! src/share/vm/opto/node.cpp ! src/share/vm/opto/node.hpp Changeset: 6cc3576e5142 Author: jcoomes Date: 2008-04-16 15:34 -0700 URL: http://hg.openjdk.java.net/jdk7/jsn/hotspot/rev/6cc3576e5142 6689788: Bump HSX12 build version number Summary: Update HSX12 build number to 03 Reviewed-by: kvn ! make/hotspot_version Changeset: ad0b851458ff Author: trims Date: 2008-04-22 15:36 -0700 URL: http://hg.openjdk.java.net/jdk7/jsn/hotspot/rev/ad0b851458ff Merge - src/share/vm/memory/allocationStats.cpp - src/share/vm/memory/allocationStats.hpp Changeset: 24706b95d959 Author: xdono Date: 2008-04-24 12:12 -0700 URL: http://hg.openjdk.java.net/jdk7/jsn/hotspot/rev/24706b95d959 Added tag jdk7-b26 for changeset ad0b851458ff ! .hgtags From bradford.wetmore at sun.com Mon May 19 11:22:34 2008 From: bradford.wetmore at sun.com (bradford.wetmore at sun.com) Date: Mon, 19 May 2008 18:22:34 +0000 Subject: hg: jdk7/jsn/jaxp: Added tag jdk7-b26 for changeset da43cb85fac1 Message-ID: <20080519182236.835D828288@hg.openjdk.java.net> Changeset: bafed478d67c Author: xdono Date: 2008-04-24 12:12 -0700 URL: http://hg.openjdk.java.net/jdk7/jsn/jaxp/rev/bafed478d67c Added tag jdk7-b26 for changeset da43cb85fac1 ! .hgtags From bradford.wetmore at sun.com Mon May 19 11:23:22 2008 From: bradford.wetmore at sun.com (bradford.wetmore at sun.com) Date: Mon, 19 May 2008 18:23:22 +0000 Subject: hg: jdk7/jsn/jaxws: Added tag jdk7-b26 for changeset debd37e1a422 Message-ID: <20080519182324.1A0472828D@hg.openjdk.java.net> Changeset: 27d8f42862c1 Author: xdono Date: 2008-04-24 12:12 -0700 URL: http://hg.openjdk.java.net/jdk7/jsn/jaxws/rev/27d8f42862c1 Added tag jdk7-b26 for changeset debd37e1a422 ! .hgtags From bradford.wetmore at sun.com Mon May 19 11:24:39 2008 From: bradford.wetmore at sun.com (bradford.wetmore at sun.com) Date: Mon, 19 May 2008 18:24:39 +0000 Subject: hg: jdk7/jsn/jdk: 17 new changesets Message-ID: <20080519182802.77D2128292@hg.openjdk.java.net> Changeset: 3226a9a5cc47 Author: xdono Date: 2008-03-27 12:28 -0700 URL: http://hg.openjdk.java.net/jdk7/jsn/jdk/rev/3226a9a5cc47 Merge Changeset: 88d235789027 Author: ohair Date: 2008-03-31 17:17 -0700 URL: http://hg.openjdk.java.net/jdk7/jsn/jdk/rev/88d235789027 6672405: OPENJDK build: jdk7/jdk/make/tools/freetypecheck leaves dirt behind Summary: OpenJDK freetype sanity check cleanup. Reviewed-by: tbell ! make/common/Defs.gmk ! make/common/shared/Sanity.gmk ! make/tools/Makefile ! make/tools/freetypecheck/Makefile Changeset: e6157955511e Author: ohair Date: 2008-03-31 17:19 -0700 URL: http://hg.openjdk.java.net/jdk7/jsn/jdk/rev/e6157955511e 6482445: j2se/make/java/java/localegen.sh uses 'sort' from PATH, could get system32/sort Summary: Making sure the right 'sort' utility is found. Reviewed-by: tbell ! make/java/java/genlocales.gmk ! make/java/java/localegen.sh Changeset: 425096dc0fc8 Author: ohair Date: 2008-03-31 17:20 -0700 URL: http://hg.openjdk.java.net/jdk7/jsn/jdk/rev/425096dc0fc8 6501543: Username can have non-alphanumeric characters Summary: User version string issues, including a L10n issue with month names. Reviewed-by: tbell ! make/common/shared/Defs.gmk Changeset: a977a69d9cf2 Author: ohair Date: 2008-04-01 15:14 -0700 URL: http://hg.openjdk.java.net/jdk7/jsn/jdk/rev/a977a69d9cf2 6482134: JDK 6 build error on Windows, Visual Studio .NET on Japanese locale Summary: Fix scanning of cl.exe version output, removed CC_TYPE. Reviewed-by: tbell ! make/common/shared/Compiler-gcc.gmk ! make/common/shared/Compiler-msvc.gmk ! make/common/shared/Sanity.gmk Changeset: fa4df2d26d9b Author: ohair Date: 2008-04-01 15:41 -0700 URL: http://hg.openjdk.java.net/jdk7/jsn/jdk/rev/fa4df2d26d9b 6627823: Missed whitespace normalization files: jdk/test/java/rmi Summary: Just missed a few files being normalized in rev 0. Reviewed-by: xdono ! test/java/rmi/activation/Activatable/createPrivateActivable/CreatePrivateActivatable.java ! test/java/rmi/activation/ActivateFailedException/activateFails/ActivateFails.java ! test/java/rmi/activation/ActivateFailedException/activateFails/ActivateFails_Stub.java ! test/java/rmi/activation/ActivateFailedException/activateFails/ActivateMe.java ! test/java/rmi/activation/ActivateFailedException/activateFails/ShutdownThread.java ! test/java/rmi/activation/ActivationGroup/downloadActivationGroup/DownloadActivationGroup.java ! test/java/rmi/activation/ActivationGroup/downloadActivationGroup/DownloadActivationGroup_Stub.java ! test/java/rmi/activation/ActivationGroup/downloadActivationGroup/MyActivationGroupImpl.java ! test/java/rmi/activation/ActivationGroupDesc/checkDefaultGroupName/CheckDefaultGroupName.java ! test/java/rmi/activation/ActivationSystem/activeGroup/IdempotentActiveGroup.java ! test/java/rmi/activation/ActivationSystem/modifyDescriptor/ActivateMe.java ! test/java/rmi/activation/ActivationSystem/modifyDescriptor/ModifyDescriptor.java ! test/java/rmi/activation/ActivationSystem/modifyDescriptor/ModifyDescriptor_Stub.java ! test/java/rmi/activation/ActivationSystem/stubClassesPermitted/CanCreateStubs.java ! test/java/rmi/activation/ActivationSystem/stubClassesPermitted/StubClassesPermitted.java ! test/java/rmi/activation/ActivationSystem/stubClassesPermitted/StubClassesPermitted_Stub.java ! test/java/rmi/activation/ActivationSystem/unregisterGroup/ActivateMe.java ! test/java/rmi/activation/ActivationSystem/unregisterGroup/CallbackInterface.java ! test/java/rmi/activation/ActivationSystem/unregisterGroup/Callback_Stub.java ! test/java/rmi/activation/ActivationSystem/unregisterGroup/UnregisterGroup.java ! test/java/rmi/activation/ActivationSystem/unregisterGroup/UnregisterGroup_Stub.java ! test/java/rmi/dgc/VMID/CheckVMID.java ! test/java/rmi/dgc/dgcAckFailure/DGCAckFailure.java ! test/java/rmi/dgc/dgcAckFailure/DGCAckFailure_Stub.java ! test/java/rmi/dgc/dgcImplInsulation/DGCImplInsulation.java ! test/java/rmi/dgc/dgcImplInsulation/DGCImplInsulation_Stub.java ! test/java/rmi/dgc/retryDirtyCalls/RetryDirtyCalls.java ! test/java/rmi/dgc/retryDirtyCalls/RetryDirtyCalls_Stub.java ! test/java/rmi/registry/altSecurityManager/AltSecurityManager.java ! test/java/rmi/registry/altSecurityManager/TestSecurityManager.java ! test/java/rmi/registry/checkusage/CheckUsage.java ! test/java/rmi/registry/classPathCodebase/ClassPathCodebase.java ! test/java/rmi/registry/classPathCodebase/Dummy.java ! test/java/rmi/registry/emptyName/EmptyName.java ! test/java/rmi/registry/interfaceHash/InterfaceHash.java ! test/java/rmi/registry/interfaceHash/ReferenceRegistryStub.java ! test/java/rmi/registry/multipleRegistries/MultipleRegistries.java ! test/java/rmi/registry/reexport/Reexport.java ! test/java/rmi/reliability/benchmark/bench/rmi/BenchServer.java ! test/java/rmi/reliability/benchmark/bench/rmi/BenchServerImpl.java ! test/java/rmi/reliability/benchmark/bench/rmi/BooleanArrayCalls.java ! test/java/rmi/reliability/benchmark/bench/rmi/BooleanCalls.java ! test/java/rmi/reliability/benchmark/bench/rmi/ByteArrayCalls.java ! test/java/rmi/reliability/benchmark/bench/rmi/ByteCalls.java ! test/java/rmi/reliability/benchmark/bench/rmi/CharArrayCalls.java ! test/java/rmi/reliability/benchmark/bench/rmi/CharCalls.java ! test/java/rmi/reliability/benchmark/bench/rmi/ClassLoading.java ! test/java/rmi/reliability/benchmark/bench/rmi/DoubleArrayCalls.java ! test/java/rmi/reliability/benchmark/bench/rmi/DoubleCalls.java ! test/java/rmi/reliability/benchmark/bench/rmi/ExceptionCalls.java ! test/java/rmi/reliability/benchmark/bench/rmi/ExportObjs.java ! test/java/rmi/reliability/benchmark/bench/rmi/FloatArrayCalls.java ! test/java/rmi/reliability/benchmark/bench/rmi/FloatCalls.java ! test/java/rmi/reliability/benchmark/bench/rmi/IntArrayCalls.java ! test/java/rmi/reliability/benchmark/bench/rmi/IntCalls.java ! test/java/rmi/reliability/benchmark/bench/rmi/LongArrayCalls.java ! test/java/rmi/reliability/benchmark/bench/rmi/LongCalls.java ! test/java/rmi/reliability/benchmark/bench/rmi/Main.java ! test/java/rmi/reliability/benchmark/bench/rmi/NullCalls.java ! test/java/rmi/reliability/benchmark/bench/rmi/ObjArrayCalls.java ! test/java/rmi/reliability/benchmark/bench/rmi/ObjTreeCalls.java ! test/java/rmi/reliability/benchmark/bench/rmi/ProxyArrayCalls.java ! test/java/rmi/reliability/benchmark/bench/rmi/RemoteObjArrayCalls.java ! test/java/rmi/reliability/benchmark/bench/rmi/ShortArrayCalls.java ! test/java/rmi/reliability/benchmark/bench/rmi/ShortCalls.java ! test/java/rmi/reliability/benchmark/bench/rmi/SmallObjTreeCalls.java ! test/java/rmi/reliability/benchmark/bench/serial/BooleanArrays.java ! test/java/rmi/reliability/benchmark/bench/serial/Booleans.java ! test/java/rmi/reliability/benchmark/bench/serial/ByteArrays.java ! test/java/rmi/reliability/benchmark/bench/serial/Bytes.java ! test/java/rmi/reliability/benchmark/bench/serial/CharArrays.java ! test/java/rmi/reliability/benchmark/bench/serial/Chars.java ! test/java/rmi/reliability/benchmark/bench/serial/ClassDesc.java ! test/java/rmi/reliability/benchmark/bench/serial/Cons.java ! test/java/rmi/reliability/benchmark/bench/serial/CustomDefaultObjTrees.java ! test/java/rmi/reliability/benchmark/bench/serial/CustomObjTrees.java ! test/java/rmi/reliability/benchmark/bench/serial/DoubleArrays.java ! test/java/rmi/reliability/benchmark/bench/serial/Doubles.java ! test/java/rmi/reliability/benchmark/bench/serial/ExternObjTrees.java ! test/java/rmi/reliability/benchmark/bench/serial/FloatArrays.java ! test/java/rmi/reliability/benchmark/bench/serial/Floats.java ! test/java/rmi/reliability/benchmark/bench/serial/GetPutFieldTrees.java ! test/java/rmi/reliability/benchmark/bench/serial/IntArrays.java ! test/java/rmi/reliability/benchmark/bench/serial/Ints.java ! test/java/rmi/reliability/benchmark/bench/serial/LongArrays.java ! test/java/rmi/reliability/benchmark/bench/serial/Longs.java ! test/java/rmi/reliability/benchmark/bench/serial/Main.java ! test/java/rmi/reliability/benchmark/bench/serial/ObjArrays.java ! test/java/rmi/reliability/benchmark/bench/serial/ObjTrees.java ! test/java/rmi/reliability/benchmark/bench/serial/ProxyArrays.java ! test/java/rmi/reliability/benchmark/bench/serial/ProxyClassDesc.java ! test/java/rmi/reliability/benchmark/bench/serial/RepeatObjs.java ! test/java/rmi/reliability/benchmark/bench/serial/ReplaceTrees.java ! test/java/rmi/reliability/benchmark/bench/serial/ShortArrays.java ! test/java/rmi/reliability/benchmark/bench/serial/Shorts.java ! test/java/rmi/reliability/benchmark/bench/serial/SmallObjTrees.java ! test/java/rmi/reliability/benchmark/bench/serial/StreamBuffer.java ! test/java/rmi/reliability/benchmark/bench/serial/Strings.java ! test/java/rmi/reliability/juicer/Apple.java ! test/java/rmi/reliability/juicer/AppleEvent.java ! test/java/rmi/reliability/juicer/AppleImpl.java ! test/java/rmi/reliability/juicer/AppleUser.java ! test/java/rmi/reliability/juicer/AppleUserImpl.java ! test/java/rmi/reliability/juicer/ApplicationServer.java ! test/java/rmi/reliability/juicer/Orange.java ! test/java/rmi/reliability/juicer/OrangeEcho.java ! test/java/rmi/reliability/juicer/OrangeEchoImpl.java ! test/java/rmi/reliability/juicer/OrangeImpl.java ! test/java/rmi/server/RMISocketFactory/useSocketFactory/activatable/CompressConstants.java ! test/java/rmi/server/RMISocketFactory/useSocketFactory/activatable/CompressInputStream.java ! test/java/rmi/server/RMISocketFactory/useSocketFactory/activatable/CompressOutputStream.java ! test/java/rmi/server/RMISocketFactory/useSocketFactory/activatable/Echo.java ! test/java/rmi/server/RMISocketFactory/useSocketFactory/activatable/EchoImpl.java ! test/java/rmi/server/RMISocketFactory/useSocketFactory/activatable/EchoImpl_Stub.java ! test/java/rmi/server/RMISocketFactory/useSocketFactory/activatable/MultiSocketFactory.java ! test/java/rmi/server/RMISocketFactory/useSocketFactory/activatable/UseCustomSocketFactory.java ! test/java/rmi/server/RMISocketFactory/useSocketFactory/registry/Compress.java ! test/java/rmi/server/RMISocketFactory/useSocketFactory/registry/Hello.java ! test/java/rmi/server/RMISocketFactory/useSocketFactory/registry/HelloImpl.java ! test/java/rmi/server/RMISocketFactory/useSocketFactory/registry/HelloImpl_Stub.java ! test/java/rmi/server/RMISocketFactory/useSocketFactory/registry/UseCustomSocketFactory.java ! test/java/rmi/server/RMISocketFactory/useSocketFactory/unicast/CompressConstants.java ! test/java/rmi/server/RMISocketFactory/useSocketFactory/unicast/CompressInputStream.java ! test/java/rmi/server/RMISocketFactory/useSocketFactory/unicast/CompressOutputStream.java ! test/java/rmi/server/RMISocketFactory/useSocketFactory/unicast/Echo.java ! test/java/rmi/server/RMISocketFactory/useSocketFactory/unicast/EchoImpl.java ! test/java/rmi/server/RMISocketFactory/useSocketFactory/unicast/EchoImpl_Stub.java ! test/java/rmi/server/RMISocketFactory/useSocketFactory/unicast/MultiSocketFactory.java ! test/java/rmi/server/RMISocketFactory/useSocketFactory/unicast/UseCustomSocketFactory.java ! test/java/rmi/server/RemoteServer/setLogPermission/SetLogPermission.java ! test/java/rmi/server/UnicastRemoteObject/changeHostName/ChangeHostName.java ! test/java/rmi/server/UnicastRemoteObject/changeHostName/ChangeHostName_Stub.java ! test/java/rmi/server/UnicastRemoteObject/keepAliveDuringCall/KeepAliveDuringCall.java ! test/java/rmi/server/UnicastRemoteObject/keepAliveDuringCall/KeepAliveDuringCall_Stub.java ! test/java/rmi/server/UnicastRemoteObject/keepAliveDuringCall/Shutdown.java ! test/java/rmi/server/UnicastRemoteObject/keepAliveDuringCall/ShutdownImpl.java ! test/java/rmi/server/UnicastRemoteObject/keepAliveDuringCall/ShutdownImpl_Stub.java ! test/java/rmi/server/UnicastRemoteObject/keepAliveDuringCall/ShutdownMonitor.java ! test/java/rmi/server/UnicastRemoteObject/marshalAfterUnexport/MarshalAfterUnexport.java ! test/java/rmi/server/UnicastRemoteObject/marshalAfterUnexport/MarshalAfterUnexport2.java ! test/java/rmi/server/UnicastRemoteObject/marshalAfterUnexport/MarshalAfterUnexport2_Stub.java ! test/java/rmi/server/UnicastRemoteObject/marshalAfterUnexport/MarshalAfterUnexport_Stub.java ! test/java/rmi/server/UnicastRemoteObject/unexportObject/Ping.java ! test/java/rmi/server/UnicastRemoteObject/unexportObject/UnexportLeak.java ! test/java/rmi/server/UnicastRemoteObject/unexportObject/UnexportLeak_Stub.java ! test/java/rmi/server/UnicastRemoteObject/useDynamicProxies/UseDynamicProxies.java ! test/java/rmi/server/UnicastRemoteObject/useDynamicProxies/UseDynamicProxies_Stub.java ! test/java/rmi/server/Unmarshal/checkUnmarshalOnStopThread/CheckUnmarshalOnStopThread.java ! test/java/rmi/server/Unmarshal/checkUnmarshalOnStopThread/CheckUnmarshalOnStopThread_Stub.java ! test/java/rmi/server/Unmarshal/checkUnmarshalOnStopThread/CheckUnmarshall.java ! test/java/rmi/server/Unmarshal/checkUnmarshalOnStopThread/PoisonPill.java ! test/java/rmi/server/Unmarshal/checkUnmarshalOnStopThread/RuntimeExceptionParameter.java ! test/java/rmi/server/Unreferenced/finiteGCLatency/FiniteGCLatency.java ! test/java/rmi/server/Unreferenced/finiteGCLatency/FiniteGCLatency_Stub.java ! test/java/rmi/server/Unreferenced/leaseCheckInterval/LeaseCheckInterval.java ! test/java/rmi/server/Unreferenced/leaseCheckInterval/LeaseCheckInterval_Stub.java ! test/java/rmi/server/Unreferenced/leaseCheckInterval/SelfTerminator.java ! test/java/rmi/server/Unreferenced/marshalledObjectGet/MarshalledObjectGet.java ! test/java/rmi/server/Unreferenced/marshalledObjectGet/MarshalledObjectGet_Stub.java ! test/java/rmi/server/Unreferenced/unreferencedContext/UnreferencedContext.java ! test/java/rmi/server/Unreferenced/unreferencedContext/UnreferencedContext_Stub.java ! test/java/rmi/transport/acceptLoop/CloseServerSocketOnTermination.java ! test/java/rmi/transport/checkFQDN/CheckFQDN.java ! test/java/rmi/transport/checkFQDN/CheckFQDNClient.java ! test/java/rmi/transport/checkFQDN/CheckFQDN_Stub.java ! test/java/rmi/transport/checkFQDN/TellServerName.java ! test/java/rmi/transport/checkLeaseInfoLeak/CheckLeaseLeak.java ! test/java/rmi/transport/checkLeaseInfoLeak/CheckLeaseLeak_Stub.java ! test/java/rmi/transport/checkLeaseInfoLeak/LeaseLeak.java ! test/java/rmi/transport/checkLeaseInfoLeak/LeaseLeakClient.java ! test/java/rmi/transport/closeServerSocket/CloseServerSocket.java ! test/java/rmi/transport/dgcDeadLock/DGCDeadLock.java ! test/java/rmi/transport/dgcDeadLock/Test.java ! test/java/rmi/transport/dgcDeadLock/TestImpl.java ! test/java/rmi/transport/dgcDeadLock/TestImpl_Stub.java ! test/java/rmi/transport/handshakeFailure/HandshakeFailure.java ! test/java/rmi/transport/handshakeTimeout/HandshakeTimeout.java ! test/java/rmi/transport/httpSocket/HttpSocketTest.java ! test/java/rmi/transport/httpSocket/HttpSocketTest_Stub.java ! test/java/rmi/transport/pinClientSocketFactory/PinClientSocketFactory.java ! test/java/rmi/transport/pinLastArguments/PinLastArguments.java ! test/java/rmi/transport/rapidExportUnexport/RapidExportUnexport.java ! test/java/rmi/transport/readTimeout/ReadTimeoutTest.java ! test/java/rmi/transport/readTimeout/TestIface.java ! test/java/rmi/transport/readTimeout/TestImpl.java ! test/java/rmi/transport/readTimeout/TestImpl_Stub.java ! test/java/rmi/transport/reuseDefaultPort/ReuseDefaultPort.java ! test/java/rmi/transport/runtimeThreadInheritanceLeak/RuntimeThreadInheritanceLeak.java ! test/java/rmi/transport/runtimeThreadInheritanceLeak/RuntimeThreadInheritanceLeak_Stub.java Changeset: 63e1f1ed9805 Author: xdono Date: 2008-04-07 17:38 -0700 URL: http://hg.openjdk.java.net/jdk7/jsn/jdk/rev/63e1f1ed9805 Merge Changeset: 68b85ce111f2 Author: ohair Date: 2008-04-14 14:52 -0700 URL: http://hg.openjdk.java.net/jdk7/jsn/jdk/rev/68b85ce111f2 6484686: The next directory looks like it is no longer part of the build (deploy makefiles) Summary: Getting rid of the _OUTPUTDIR settings. Using BUILD_PARENT_DIRECTORY instead. This solves problems with the "/build/windows-i586*" paths getting mangled on Windows builds (fastdebug builds in particular). Reviewed-by: tbell ! make/common/shared/Defs-control.gmk Changeset: eac50a34a8e0 Author: xdono Date: 2008-04-18 13:24 -0700 URL: http://hg.openjdk.java.net/jdk7/jsn/jdk/rev/eac50a34a8e0 Merge ! make/common/shared/Defs.gmk Changeset: b1bbd90b0c4f Author: ohair Date: 2008-04-18 12:47 -0700 URL: http://hg.openjdk.java.net/jdk7/jsn/jdk/rev/b1bbd90b0c4f 6641585: jdk/make/javax/Makefile should not have both SUBDIRS and AUTO_FILES_JAVA_DIRS Summary: Separated Makefile logic, subtree walk vs. javac compiles. Also fixed minor issue in Rules.gmk. Reviewed-by: tbell ! make/common/Rules.gmk ! make/javax/Makefile + make/javax/others/Makefile Changeset: fb57027902e0 Author: ohair Date: 2008-04-18 16:40 -0700 URL: http://hg.openjdk.java.net/jdk7/jsn/jdk/rev/fb57027902e0 Merge Changeset: 256d28e3fd98 Author: xdono Date: 2008-04-24 12:12 -0700 URL: http://hg.openjdk.java.net/jdk7/jsn/jdk/rev/256d28e3fd98 Added tag jdk7-b26 for changeset fb57027902e0 ! .hgtags Changeset: 2249879c6f22 Author: tbell Date: 2008-04-25 15:18 -0700 URL: http://hg.openjdk.java.net/jdk7/jsn/jdk/rev/2249879c6f22 Merge ! make/tools/Makefile Changeset: 2bf15b903bec Author: tbell Date: 2008-05-12 18:06 -0700 URL: http://hg.openjdk.java.net/jdk7/jsn/jdk/rev/2bf15b903bec Merge Changeset: 94ded5c8cfba Author: emcmanus Date: 2008-05-14 18:38 +0200 URL: http://hg.openjdk.java.net/jdk7/jsn/jdk/rev/94ded5c8cfba 6701459: Synchronization bug pattern found in javax.management.relation.RelationService Summary: Fixed this and many other problems found by FindBugs. Reviewed-by: dfuchs ! src/share/classes/com/sun/jmx/interceptor/DefaultMBeanServerInterceptor.java ! src/share/classes/com/sun/jmx/mbeanserver/MBeanInstantiator.java ! src/share/classes/com/sun/jmx/mbeanserver/Repository.java ! src/share/classes/com/sun/jmx/remote/internal/ClientNotifForwarder.java ! src/share/classes/com/sun/jmx/remote/internal/ServerNotifForwarder.java ! src/share/classes/com/sun/jmx/remote/security/FileLoginModule.java ! src/share/classes/com/sun/jmx/remote/security/JMXPluggableAuthenticator.java ! src/share/classes/com/sun/jmx/remote/security/MBeanServerFileAccessController.java ! src/share/classes/javax/management/NumericValueExp.java ! src/share/classes/javax/management/ObjectName.java ! src/share/classes/javax/management/StandardMBean.java ! src/share/classes/javax/management/loading/MLet.java ! src/share/classes/javax/management/loading/MLetParser.java ! src/share/classes/javax/management/modelmbean/DescriptorSupport.java ! src/share/classes/javax/management/modelmbean/ModelMBeanAttributeInfo.java ! src/share/classes/javax/management/modelmbean/ModelMBeanConstructorInfo.java ! src/share/classes/javax/management/modelmbean/ModelMBeanInfoSupport.java ! src/share/classes/javax/management/modelmbean/ModelMBeanNotificationInfo.java ! src/share/classes/javax/management/modelmbean/ModelMBeanOperationInfo.java ! src/share/classes/javax/management/modelmbean/RequiredModelMBean.java ! src/share/classes/javax/management/monitor/CounterMonitor.java ! src/share/classes/javax/management/monitor/GaugeMonitor.java ! src/share/classes/javax/management/monitor/Monitor.java ! src/share/classes/javax/management/openmbean/ArrayType.java ! src/share/classes/javax/management/openmbean/CompositeType.java ! src/share/classes/javax/management/openmbean/OpenMBeanAttributeInfoSupport.java ! src/share/classes/javax/management/openmbean/OpenMBeanConstructorInfoSupport.java ! src/share/classes/javax/management/openmbean/OpenMBeanInfoSupport.java ! src/share/classes/javax/management/openmbean/SimpleType.java ! src/share/classes/javax/management/openmbean/TabularType.java ! src/share/classes/javax/management/relation/RelationNotification.java ! src/share/classes/javax/management/relation/RelationService.java ! src/share/classes/javax/management/relation/RelationSupport.java ! src/share/classes/javax/management/remote/JMXConnectorFactory.java ! src/share/classes/javax/management/remote/JMXConnectorServerFactory.java ! src/share/classes/javax/management/remote/JMXServiceURL.java ! src/share/classes/javax/management/remote/rmi/RMIConnector.java ! src/share/classes/javax/management/remote/rmi/RMIConnectorServer.java ! src/share/classes/javax/management/timer/Timer.java Changeset: 1483094a7c17 Author: emcmanus Date: 2008-05-16 11:34 +0200 URL: http://hg.openjdk.java.net/jdk7/jsn/jdk/rev/1483094a7c17 6703552: Missing files from changeset for 6701459 Summary: Previous push missed a small number of files. Reviewed-by: dfuchs ! src/share/classes/javax/management/openmbean/OpenMBeanOperationInfoSupport.java ! src/share/classes/javax/management/relation/RelationService.java ! src/share/classes/javax/management/timer/Timer.java + test/javax/management/relation/RelationNotificationSeqNoTest.java Changeset: d3dfeb4295b3 Author: wetmore Date: 2008-05-17 00:27 -0700 URL: http://hg.openjdk.java.net/jdk7/jsn/jdk/rev/d3dfeb4295b3 Merge From bradford.wetmore at sun.com Mon May 19 11:33:53 2008 From: bradford.wetmore at sun.com (bradford.wetmore at sun.com) Date: Mon, 19 May 2008 18:33:53 +0000 Subject: hg: jdk7/jsn/langtools: 3 new changesets Message-ID: <20080519183358.D1F902829C@hg.openjdk.java.net> Changeset: 3c41acaad702 Author: xdono Date: 2008-04-24 12:12 -0700 URL: http://hg.openjdk.java.net/jdk7/jsn/langtools/rev/3c41acaad702 Added tag jdk7-b26 for changeset c46d25a2350a ! .hgtags Changeset: eb4c60ad2fa2 Author: tbell Date: 2008-04-25 15:22 -0700 URL: http://hg.openjdk.java.net/jdk7/jsn/langtools/rev/eb4c60ad2fa2 Merge Changeset: a17265993253 Author: tbell Date: 2008-05-12 18:07 -0700 URL: http://hg.openjdk.java.net/jdk7/jsn/langtools/rev/a17265993253 Merge From bradford.wetmore at sun.com Thu May 22 16:10:33 2008 From: bradford.wetmore at sun.com (bradford.wetmore at sun.com) Date: Thu, 22 May 2008 23:10:33 +0000 Subject: hg: jdk7/jsn/jdk: 6706358: jdk/test/sun/security/pkcs11/Cipher/TestSymmCiphers.java has the wrong copyright notice. Message-ID: <20080522231055.7209B2859B@hg.openjdk.java.net> Changeset: f8049c6ff629 Author: wetmore Date: 2008-05-22 14:20 -0700 URL: http://hg.openjdk.java.net/jdk7/jsn/jdk/rev/f8049c6ff629 6706358: jdk/test/sun/security/pkcs11/Cipher/TestSymmCiphers.java has the wrong copyright notice. Reviewed-by: valeriep ! test/sun/security/pkcs11/Cipher/TestSymmCiphers.java From Alan.Bateman at Sun.COM Fri May 23 02:20:57 2008 From: Alan.Bateman at Sun.COM (Alan Bateman) Date: Fri, 23 May 2008 10:20:57 +0100 Subject: network tests In-Reply-To: <48361B59.1090808@sun.com> References: <48361B59.1090808@sun.com> Message-ID: <48368C79.8050307@sun.com> Joe Darcy wrote: > Greetings. > > Recently Mark Wielaard started an effort to run the regression tests > on OpenJDK builds and publish the results > (http://mail.openjdk.java.net/pipermail/distro-pkg-dev/2008-May/001921.html). > Certain tests in the nio and networking area assume Sun-internal > hosts like javaweb are available; the shell test > > test/java/net/InetAddress/ptr/lookup.sh > > has a string for javaweb and > > test/java/nio/channels/TestUtil.java > > has the following constants used by other tests: > > // Test hosts used by the channels tests - change these when > // executing in a different network. > public static final String HOST = "javaweb.sfbay.sun.com"; > public static final String REFUSING_HOST = "jano.sfbay.sun.com"; > public static final String FAR_HOST = "theclub.ireland.sun.com"; > public static final String UNRESOLVABLE_HOST = > "blah-blah.blah-blah.blah"; > > Mark observed these three hosts are needed: >> With daytime and echo available. The only wrinkle is that some tests >> expect to be able to use quick timeouts from HOST, but to need long >> timeouts from FAR_HOST. I think we could provide something public for >> this. But I might have missed some tests that need other services. Do >> you have a full overview? > (http://mail.openjdk.java.net/pipermail/distro-pkg-dev/2008-May/001972.html) > > > First, is this all the networking configuration information that is > used in the regression tests? For the tests in the java/nio and sun/nio tree then the dependencies are centralized in TestUtil.java. When we moved these tests from closed->open we did talk about moving this configuration into a properties/configuration file but figured there wasn't much difference between editing a config file vs. a source file. For the classic networking, the dependencies are scattered. I believe some of the tests weren't moved from closed->open for this reason. Some of the tests uses an embedded HTTP or FTP server but there are others that depend on DNS, proxy, etc. Michael or Jessie may have more to say on this. BTW: I briefly scanned the summary and most of the java/nio failures appear to be *HOST related. Now that folks are running these tests outside Sun it is time to own up to a few intermittent/timing related failures with 4 or 5 of these tests. I've been meaning to fix these test issues for a while but I haven't had the cycles. I'll dig up my notes on these. One other thing - I notice test/java/nio/channels/DatagramChannel/NotBound.java on the list - that test is failing because it is missing the public modifier. The test is bogus anyway so it might be best to just remove this test from jdk6 and open6. For jdk7/OpenJDK I have spec clarification in the works to fix the spec hole and as part of that work the test will be replaced (see 6621689). > Second, it would be helpful is this host information could be > configured without changing the sources of the test each time. I've > spoken briefly to Jon about ways this kind of information can be > passed into a jtreg run. Environment variables can be used, as can > system properties. A system property could also be used to specify a > file from which the information was read. With a bit of jtreg > hacking, it is feasible portions of the jtharness interview procedure > could be exposed to configure information that way too. I would be concerned with a solution that requires environment variables or jtreg requiring configuration from somewhere other than the test suite. At least in Sun (sorry for being selfish), these tests are run by various teams on hundreds of machines. I don't think we'd want to require the javatest interview be run or have .jti files stored in various places with configuration information that will quickly go stale. If you mean that the configuration can be overridden via some input to jtreg that might be okay but would require the distributions and others to maintain that configuration. Anyway, I'm interested to hear the outcome of the discussion. -Alan. From Jean-Christophe.Collet at Sun.COM Fri May 23 08:20:28 2008 From: Jean-Christophe.Collet at Sun.COM (Jean-Christophe Collet) Date: Fri, 23 May 2008 17:20:28 +0200 Subject: A proposal for a FTP client API Message-ID: <4836E0BC.4000902@sun.com> Hello, I have posted an entry in my blog about the current status of the FTP client API. It contains a quick description of the project as well as a link to the current draft of the API. So if you're interested in that topic go take a look at http://blogs.sun.com/jcc/ As mentioned in the post, feedback is very strongly encouraged. From Weijun.Wang at Sun.COM Fri May 23 09:15:36 2008 From: Weijun.Wang at Sun.COM (Max (Weijun) Wang) Date: Sat, 24 May 2008 00:15:36 +0800 Subject: A proposal for a FTP client API In-Reply-To: <4836E0BC.4000902@sun.com> References: <4836E0BC.4000902@sun.com> Message-ID: <6913B8DB-07CB-4D62-BC79-16D4151D7A00@sun.com> boolean login(String user, String password) boolean login(String user, String password, String account) Normally we use char[] to represent a password so that it can zeroed out afterward. List listFiles(String path) If a FTP directory is huge, listing the files will cost a very long time. I'll be very glad to see this method returns immediately and fetching the information while user iterate through the output. Is this implementation possible with this API? Thanks Max On May 23, 2008, at 11:20 PM, Jean-Christophe Collet wrote: > Hello, > > I have posted an entry in my blog about the current status of the > FTP client API. > It contains a quick description of the project as well as a link to > the current draft of the API. So if you're interested in that topic > go take a look at http://blogs.sun.com/jcc/ > > As mentioned in the post, feedback is very strongly encouraged. > > From david.lloyd at redhat.com Fri May 23 09:17:40 2008 From: david.lloyd at redhat.com (David M. Lloyd) Date: Fri, 23 May 2008 11:17:40 -0500 Subject: A proposal for a FTP client API In-Reply-To: <4836E0BC.4000902@sun.com> References: <4836E0BC.4000902@sun.com> Message-ID: <4836EE24.4060000@redhat.com> On 05/23/2008 10:20 AM, Jean-Christophe Collet wrote: > Hello, > > I have posted an entry in my blog about the current status of the FTP > client API. > It contains a quick description of the project as well as a link to the > current draft of the API. So if you're interested in that topic go take > a look at http://blogs.sun.com/jcc/ > > As mentioned in the post, feedback is very strongly encouraged. This is going into the java.net package - is there/will there be a JSR for this effort? - DML From david.lloyd at redhat.com Fri May 23 09:25:34 2008 From: david.lloyd at redhat.com (David M. Lloyd) Date: Fri, 23 May 2008 11:25:34 -0500 Subject: A proposal for a FTP client API In-Reply-To: <4836E0BC.4000902@sun.com> References: <4836E0BC.4000902@sun.com> Message-ID: <4836EFFE.4040109@redhat.com> On 05/23/2008 10:20 AM, Jean-Christophe Collet wrote: > Hello, > > I have posted an entry in my blog about the current status of the FTP > client API. > [..] > As mentioned in the post, feedback is very strongly encouraged. Some technical feedback: 1) FtpClient should implement java.io.Closeable in my opinion. 2) I also feel that listFiles should stream output. How about returning Iterable instead? It could return a one-time-use Iterator, allowing users to use the extended for-loop syntax if they wish. 3) If this is going into JDK 7 - is there any way to reuse any of the FileSystem stuff from JSR-203? I'm thinking specifically of the way they handle file permissions with FileAttributeViews and so forth, but perhaps there's things which can be reused as well. Guess that's all I've got for now. - DML From Alan.Bateman at Sun.COM Fri May 23 10:27:45 2008 From: Alan.Bateman at Sun.COM (Alan Bateman) Date: Fri, 23 May 2008 18:27:45 +0100 Subject: A proposal for a FTP client API In-Reply-To: <4836E0BC.4000902@sun.com> References: <4836E0BC.4000902@sun.com> Message-ID: <4836FE91.7060007@sun.com> Jean-Christophe Collet wrote: > Hello, > > I have posted an entry in my blog about the current status of the FTP > client API. > It contains a quick description of the project as well as a link to > the current draft of the API. So if you're interested in that topic go > take a look at http://blogs.sun.com/jcc/ > > As mentioned in the post, feedback is very strongly encouraged. > > I'm interested in reviewing this. From an initial glance this is ftp and ftps - are you also thinking about sftp? Some initial comments from a first pass: It would be better to use a static factory method rather than public constructors. For one thing, there are a slew of ftp clients about and you'll likely get requests for a provider interface so that alternative implementations can be used. The client has state (not connected, connected, logged, etc.) and you might want to introduce a few specific exceptions for this. For example, what does connect throw if you are already connected, what do the other methods throw when you aren't connected, etc. In current draft there are quite a few methods that return a boolean and throw IOException. It's not clear to me what what failure means - do these methods return false or do they throw an I/O exception? How is this used with the getLastReplyCode method or should the exception have a method to return the reply code? The listFiles returns a List and isn't going to scale with large directories (you'll have to fetch the entire directory from the server for this method to return). It would be better to return something that implements Iterable and Closeable. I'm curious about FtpFile. My memory of the ftp protocol is hazy but I thought that commands such as LIST or NLIST didn't specify the format of the file attributes. There was a IEFT WG working on defining these but I don't see this in the references. Do you have a pointer to that? I see that the getModificationTime returns a Date. Care to revise your statement sir :-) You've got a number of setter methods that return void. It might be nicer for them to return this so as to facilitate invocation chaining. Should the members of the TransferMode enum be in uppercase? Do you really need the ability to set/get the connect timeout and allow it be overridden by the connect method? That's it for a first pass. -Alan. From Alan.Bateman at Sun.COM Sat May 24 06:29:15 2008 From: Alan.Bateman at Sun.COM (Alan Bateman) Date: Sat, 24 May 2008 14:29:15 +0100 Subject: network tests In-Reply-To: <48375729.2000301@sun.com> References: <48361B59.1090808@sun.com> <48368C79.8050307@sun.com> <48375729.2000301@sun.com> Message-ID: <4838182B.8090709@sun.com> Joe Darcy wrote: > : > Could the classic networking tests be refactored a bit to be > centralized like the nio tests? Would it be natural for classic > networking and nio to get their host information from the same place? There was a time when the networking tests had dependencies on quite a few web servers, proxies, etc. but there was effort to replace these tests so there should only be a few dependencies remaining. I briefly looked at the tests today and I was surprised to only find one test that attempts a lookup of a Sun internal host. The other tests with dependencies weren't moved from closed->open. In any case, it should be straight-forward to centralize the dependencies into one place. > > : > Even if the Sun-internal settings remain baked in, I think an easy way > to pass in a limited number of configuration settings is appropriate > and shouldn't be too hard to accommodate in the test code. Presumably > an interface like "openjtreg -Dmy.config.options=foo ..." wouldn't be > too awkward to use. If by "baked in" you mean a default configuration file for when the property or other knob isn't used then it seems reasonable. Are you thinking of passing in the individual parameters as properties or have one property to locate a properties/config file with the settings? -Alan. From Jean-Christophe.Collet at Sun.COM Mon May 26 01:52:01 2008 From: Jean-Christophe.Collet at Sun.COM (Jean-Christophe Collet) Date: Mon, 26 May 2008 10:52:01 +0200 Subject: A proposal for a FTP client API In-Reply-To: <6913B8DB-07CB-4D62-BC79-16D4151D7A00@sun.com> References: <4836E0BC.4000902@sun.com> <6913B8DB-07CB-4D62-BC79-16D4151D7A00@sun.com> Message-ID: <483A7A31.6080502@sun.com> Max (Weijun) Wang wrote: > boolean login(String user, String password) > boolean login(String user, String password, String account) > > Normally we use char[] to represent a password so that it can > zeroed out afterward. > Good point, I'll make the necessary changes. > List listFiles(String path) > > If a FTP directory is huge, listing the files will cost a very > long time. I'll be very glad to see this method returns immediately > and fetching the information while user iterate through the output. Is > this implementation possible with this API? Not with the current design. However, it is possible to get the 'raw' listing using FtpClient.list(String path) instead. It returns an InputStream to the unparsed listing. > > Thanks > Max > > On May 23, 2008, at 11:20 PM, Jean-Christophe Collet wrote: >> Hello, >> >> I have posted an entry in my blog about the current status of the FTP >> client API. >> It contains a quick description of the project as well as a link to >> the current draft of the API. So if you're interested in that topic >> go take a look at http://blogs.sun.com/jcc/ >> >> As mentioned in the post, feedback is very strongly encouraged. >> >> > From Jean-Christophe.Collet at Sun.COM Mon May 26 01:53:29 2008 From: Jean-Christophe.Collet at Sun.COM (Jean-Christophe Collet) Date: Mon, 26 May 2008 10:53:29 +0200 Subject: A proposal for a FTP client API In-Reply-To: <4836EE24.4060000@redhat.com> References: <4836E0BC.4000902@sun.com> <4836EE24.4060000@redhat.com> Message-ID: <483A7A89.5030701@sun.com> David M. Lloyd wrote: > On 05/23/2008 10:20 AM, Jean-Christophe Collet wrote: >> Hello, >> >> I have posted an entry in my blog about the current status of the FTP >> client API. >> It contains a quick description of the project as well as a link to >> the current draft of the API. So if you're interested in that topic >> go take a look at http://blogs.sun.com/jcc/ >> >> As mentioned in the post, feedback is very strongly encouraged. > > This is going into the java.net package - is there/will there be a JSR > for this effort? Not a separate JSR no, it is too small of a change to justify its own JSR. However it will be covered by the JDK7 blanket JSR. From Jean-Christophe.Collet at Sun.COM Mon May 26 02:16:09 2008 From: Jean-Christophe.Collet at Sun.COM (Jean-Christophe Collet) Date: Mon, 26 May 2008 11:16:09 +0200 Subject: A proposal for a FTP client API In-Reply-To: <4836FE91.7060007@sun.com> References: <4836E0BC.4000902@sun.com> <4836FE91.7060007@sun.com> Message-ID: <483A7FD9.6000704@sun.com> Alan Bateman wrote: > Jean-Christophe Collet wrote: >> Hello, >> >> I have posted an entry in my blog about the current status of the FTP >> client API. >> It contains a quick description of the project as well as a link to >> the current draft of the API. So if you're interested in that topic >> go take a look at http://blogs.sun.com/jcc/ >> >> As mentioned in the post, feedback is very strongly encouraged. >> >> > I'm interested in reviewing this. From an initial glance this is ftp > and ftps - are you also thinking about sftp? Some initial comments > from a first pass: > > It would be better to use a static factory method rather than public > constructors. For one thing, there are a slew of ftp clients about and > you'll likely get requests for a provider interface so that > alternative implementations can be used. Good point. Current design inherited a lot from the existing sun.net.ftp.FtpClient code (for obvious compatibility reasons), but that's definitely one thing we can improve. > > The client has state (not connected, connected, logged, etc.) and you > might want to introduce a few specific exceptions for this. For > example, what does connect throw if you are already connected, what do > the other methods throw when you aren't connected, etc. > > In current draft there are quite a few methods that return a boolean > and throw IOException. It's not clear to me what what failure means - > do these methods return false or do they throw an I/O exception? How > is this used with the getLastReplyCode method or should the exception > have a method to return the reply code? > The idea is to differentiate errors reported by the FTP server (aka non fatal errors), like 'bad login' or file not found, from the serious networking errors (connection lost, no route to host etc...). In the first case, the current connection can still be used for other attempts, while in the second case it's more likely too serious to recover. > The listFiles returns a List and isn't going to scale with > large directories (you'll have to fetch the entire directory from the > server for this method to return). It would be better to return > something that implements Iterable and Closeable. > This seems a common concern. I'll update the API accordingly. > I'm curious about FtpFile. My memory of the ftp protocol is hazy but I > thought that commands such as LIST or NLIST didn't specify the format > of the file attributes. There was a IEFT WG working on defining these > but I don't see this in the references. Do you have a pointer to that? They don't. That's why the API provides a pluggable 'directory parser'. By default we provide a parser that is able to 'grok' most of what is out there, but in case it's needed, the application can provide its own. > > I see that the getModificationTime returns a Date. Care to revise your > statement sir :-) > Shows how long this API has been in the working.... I will change that. > You've got a number of setter methods that return void. It might be > nicer for them to return this so as to facilitate invocation chaining. > Good point. > Should the members of the TransferMode enum be in uppercase? > Probably. Same for TransferType (and I probably should remove EBCDIC since it's not really supported). > Do you really need the ability to set/get the connect timeout and > allow it be overridden by the connect method? > I guess this is a bit redundant. Will clarify. > That's it for a first pass. Thanks, From weijun.wang at sun.com Mon May 26 23:30:39 2008 From: weijun.wang at sun.com (weijun.wang at sun.com) Date: Tue, 27 May 2008 06:30:39 +0000 Subject: hg: jdk7/jsn/jdk: 6705313: Incorrect exit $? in keytool's autotest.sh Message-ID: <20080527063102.228AE286B1@hg.openjdk.java.net> Changeset: ead7a5f601d5 Author: weijun Date: 2008-05-27 14:29 +0800 URL: http://hg.openjdk.java.net/jdk7/jsn/jdk/rev/ead7a5f601d5 6705313: Incorrect exit $? in keytool's autotest.sh Reviewed-by: valeriep ! test/sun/security/tools/keytool/autotest.sh From Jonathan.Gibbons at Sun.COM Sun May 25 08:08:52 2008 From: Jonathan.Gibbons at Sun.COM (Jonathan Gibbons) Date: Sun, 25 May 2008 15:08:52 -0000 Subject: network tests In-Reply-To: <4838182B.8090709@sun.com> References: <48361B59.1090808@sun.com> <48368C79.8050307@sun.com> <48375729.2000301@sun.com> <4838182B.8090709@sun.com> Message-ID: Alan, I can imagine two possibilities here: 1) pass a system property to each test that defines a config file in properties format that canbe read by any test that needs it 2) allow a new option to main/applet/shell tests that define a config value that will be passed to the test via a system property or environment variable. Eg @run main/config=XYZ The former requires less change to the test but does require the test to be able to read files. The latter is a bigger change to the spec but doesn't run into any security manager issues. -- Jon On May 24, 2008, at 6:29 AM, Alan Bateman wrote: > Joe Darcy wrote: >> : >> Could the classic networking tests be refactored a bit to be >> centralized like the nio tests? Would it be natural for classic >> networking and nio to get their host information from the same place? > There was a time when the networking tests had dependencies on quite > a few web servers, proxies, etc. but there was effort to replace > these tests so there should only be a few dependencies remaining. I > briefly looked at the tests today and I was surprised to only find > one test that attempts a lookup of a Sun internal host. The other > tests with dependencies weren't moved from closed->open. In any > case, it should be straight-forward to centralize the dependencies > into one place. > >> >> : >> Even if the Sun-internal settings remain baked in, I think an easy >> way to pass in a limited number of configuration settings is >> appropriate and shouldn't be too hard to accommodate in the test >> code. Presumably an interface like "openjtreg - >> Dmy.config.options=foo ..." wouldn't be too awkward to use. > If by "baked in" you mean a default configuration file for when the > property or other knob isn't used then it seems reasonable. Are you > thinking of passing in the individual parameters as properties or > have one property to locate a properties/config file with the > settings? > > -Alan. From Joe.Darcy at Sun.COM Thu May 22 18:18:28 2008 From: Joe.Darcy at Sun.COM (Joe Darcy) Date: Fri, 23 May 2008 01:18:28 -0000 Subject: network tests Message-ID: <48361B59.1090808@sun.com> Greetings. Recently Mark Wielaard started an effort to run the regression tests on OpenJDK builds and publish the results (http://mail.openjdk.java.net/pipermail/distro-pkg-dev/2008-May/001921.html). Certain tests in the nio and networking area assume Sun-internal hosts like javaweb are available; the shell test test/java/net/InetAddress/ptr/lookup.sh has a string for javaweb and test/java/nio/channels/TestUtil.java has the following constants used by other tests: // Test hosts used by the channels tests - change these when // executing in a different network. public static final String HOST = "javaweb.sfbay.sun.com"; public static final String REFUSING_HOST = "jano.sfbay.sun.com"; public static final String FAR_HOST = "theclub.ireland.sun.com"; public static final String UNRESOLVABLE_HOST = "blah-blah.blah-blah.blah"; Mark observed these three hosts are needed: > With daytime and echo available. The only wrinkle is that some tests > expect to be able to use quick timeouts from HOST, but to need long > timeouts from FAR_HOST. I think we could provide something public for > this. But I might have missed some tests that need other services. Do > you have a full overview? (http://mail.openjdk.java.net/pipermail/distro-pkg-dev/2008-May/001972.html) First, is this all the networking configuration information that is used in the regression tests? Second, it would be helpful is this host information could be configured without changing the sources of the test each time. I've spoken briefly to Jon about ways this kind of information can be passed into a jtreg run. Environment variables can be used, as can system properties. A system property could also be used to specify a file from which the information was read. With a bit of jtreg hacking, it is feasible portions of the jtharness interview procedure could be exposed to configure information that way too. -Joe From Joe.Darcy at Sun.COM Fri May 23 16:45:45 2008 From: Joe.Darcy at Sun.COM (Joe Darcy) Date: Fri, 23 May 2008 23:45:45 -0000 Subject: network tests In-Reply-To: <48368C79.8050307@sun.com> References: <48361B59.1090808@sun.com> <48368C79.8050307@sun.com> Message-ID: <48375729.2000301@sun.com> Alan Bateman wrote: > Joe Darcy wrote: >> Greetings. >> >> Recently Mark Wielaard started an effort to run the regression tests >> on OpenJDK builds and publish the results >> (http://mail.openjdk.java.net/pipermail/distro-pkg-dev/2008-May/001921.html). >> Certain tests in the nio and networking area assume Sun-internal >> hosts like javaweb are available; the shell test >> >> test/java/net/InetAddress/ptr/lookup.sh >> >> has a string for javaweb and >> >> test/java/nio/channels/TestUtil.java >> >> has the following constants used by other tests: >> >> // Test hosts used by the channels tests - change these when >> // executing in a different network. >> public static final String HOST = "javaweb.sfbay.sun.com"; >> public static final String REFUSING_HOST = "jano.sfbay.sun.com"; >> public static final String FAR_HOST = "theclub.ireland.sun.com"; >> public static final String UNRESOLVABLE_HOST = >> "blah-blah.blah-blah.blah"; >> >> Mark observed these three hosts are needed: >>> With daytime and echo available. The only wrinkle is that some tests >>> expect to be able to use quick timeouts from HOST, but to need long >>> timeouts from FAR_HOST. I think we could provide something public for >>> this. But I might have missed some tests that need other services. Do >>> you have a full overview? >> (http://mail.openjdk.java.net/pipermail/distro-pkg-dev/2008-May/001972.html) >> >> >> First, is this all the networking configuration information that is >> used in the regression tests? > For the tests in the java/nio and sun/nio tree then the dependencies > are centralized in TestUtil.java. When we moved these tests from > closed->open we did talk about moving this configuration into a > properties/configuration file but figured there wasn't much difference > between editing a config file vs. a source file. I think being able to pass in your own config file would be useful for this use case; it is awkward to have to edit the source to the tests to get them to pass :-) If -Dnetworking.test.config.file were defined, the test could use those values instead of the defaults... > > For the classic networking, the dependencies are scattered. I believe > some of the tests weren't moved from closed->open for this reason. > Some of the tests uses an embedded HTTP or FTP server but there are > others that depend on DNS, proxy, etc. Michael or Jessie may have more > to say on this. Could the classic networking tests be refactored a bit to be centralized like the nio tests? Would it be natural for classic networking and nio to get their host information from the same place? > > BTW: I briefly scanned the summary and most of the java/nio failures > appear to be *HOST related. Now that folks are running these tests > outside Sun it is time to own up to a few intermittent/timing related > failures with 4 or 5 of these tests. I've been meaning to fix these > test issues for a while but I haven't had the cycles. I'll dig up my > notes on these. One other thing - I notice > test/java/nio/channels/DatagramChannel/NotBound.java on the list - > that test is failing because it is missing the public modifier. The > test is bogus anyway so it might be best to just remove this test from > jdk6 and open6. For jdk7/OpenJDK I have spec clarification in the > works to fix the spec hole and as part of that work the test will be > replaced (see 6621689). Yes, fixing the intermittent failures and removing the invalid test in OpenJDK 6 sounds good. >> Second, it would be helpful is this host information could be >> configured without changing the sources of the test each time. I've >> spoken briefly to Jon about ways this kind of information can be >> passed into a jtreg run. Environment variables can be used, as can >> system properties. A system property could also be used to specify a >> file from which the information was read. With a bit of jtreg >> hacking, it is feasible portions of the jtharness interview procedure >> could be exposed to configure information that way too. > I would be concerned with a solution that requires environment > variables or jtreg requiring configuration from somewhere other than > the test suite. At least in Sun (sorry for being selfish), these tests > are run by various teams on hundreds of machines. I don't think we'd > want to require the javatest interview be run or have .jti files > stored in various places with configuration information that will > quickly go stale. If you mean that the configuration can be overridden > via some input to jtreg that might be okay but would require the > distributions and others to maintain that configuration. Anyway, I'm > interested to hear the outcome of the discussion. Even if the Sun-internal settings remain baked in, I think an easy way to pass in a limited number of configuration settings is appropriate and shouldn't be too hard to accommodate in the test code. Presumably an interface like "openjtreg -Dmy.config.options=foo ..." wouldn't be too awkward to use. -Joe From Joe.Darcy at Sun.COM Tue May 27 09:23:28 2008 From: Joe.Darcy at Sun.COM (Joseph D. Darcy) Date: Tue, 27 May 2008 16:23:28 -0000 Subject: network tests In-Reply-To: <4838182B.8090709@sun.com> References: <48361B59.1090808@sun.com> <48368C79.8050307@sun.com> <48375729.2000301@sun.com> <4838182B.8090709@sun.com> Message-ID: <483C356E.2070300@sun.com> Alan Bateman wrote: > Joe Darcy wrote: >> : >> Could the classic networking tests be refactored a bit to be >> centralized like the nio tests? Would it be natural for classic >> networking and nio to get their host information from the same place? > There was a time when the networking tests had dependencies on quite a > few web servers, proxies, etc. but there was effort to replace these > tests so there should only be a few dependencies remaining. I briefly > looked at the tests today and I was surprised to only find one test that > attempts a lookup of a Sun internal host. The other tests with > dependencies weren't moved from closed->open. In any case, it should be > straight-forward to centralize the dependencies into one place. > >> >> : >> Even if the Sun-internal settings remain baked in, I think an easy way >> to pass in a limited number of configuration settings is appropriate >> and shouldn't be too hard to accommodate in the test code. Presumably >> an interface like "openjtreg -Dmy.config.options=foo ..." wouldn't be >> too awkward to use. > If by "baked in" you mean a default configuration file for when the > property or other knob isn't used then it seems reasonable. Are you > thinking of passing in the individual parameters as properties or have > one property to locate a properties/config file with the settings? I was thinking of one property to locate the properties/config file. What to you think Mark? -Joe