Request for Review 6882594
Christopher Hegarty -Sun Microsystems Ireland
Christopher.Hegarty at Sun.COM
Thu Sep 17 06:10:20 PDT 2009
Max (Weijun) Wang wrote:
> I think "if (authScheme.equals(BASIC))" can be written as "authScheme
> == BASIC", and possibly you can use switch/case in several places
Thanks Max, these changes certainly make the code more readable.
Updated webrev can be found at:
> On Sep 17, 2009, at 6:55 PM, Christopher Hegarty -Sun Microsystems
> Ireland wrote:
>> I removed the use of char (schemeId) completed and replaced it the the
>> new AuthScheme enum. This makes the code much cleaner. Thanks Max and
>> Alan for this suggestion.
>> Updated webrev can be found at:
>> Christopher Hegarty - Sun Microsystems Ireland wrote:
>>> Hi Jessie, Michael, Alan,
>>> 6882594: Remove static dependency on NTLM authentication
>>> The HTTP client implementation
>>> (sun.net.www.protocol.http.HttpURLConnection) loads the NTLM
>>> Authentication classes even if no authentication is used. These
>>> classes should not be loaded unless required. Also, make NTLM a
>>> runtime dependency rather than a static one.
>>> I took the liberty of cleaning up some imports along the way.
More information about the net-dev