Request for Review 6718504: IN6_IS_ADDR_ANY tests only 12 bytes of 16-byte address
Alan.Bateman at Sun.COM
Mon Apr 26 06:37:51 PDT 2010
Chris Hegarty wrote:
> Hi Alan,
> net_util_md.h incorrectly defines the macro IN6_IS_ADDR_ANY to only
> look at 12 bytes of the 16 byte address. This causes a bind to ::1 to
> be treated as if it were a bind to the wildcard address.
> Note: with the addition of the dual stack native implementation on
> Vista this code is only executed when running IPv6 on Windows XP.
The change looks fine to me. In the test it might be simpler to put the
lookup of the IPv6 loopback address in the main method. Also, you can
probably call getLocalAddress.
More information about the net-dev