Request for Review: 6905552
Alan.Bateman at Sun.COM
Wed Jan 27 06:55:24 PST 2010
Christopher Hegarty - Sun Microsystems Ireland wrote:
> Hi Alan, Michael,
> Since we don't typically build on non-IPv6 systems, over a number of
> years the net/nio code has not maintained clean non-IPv6 code. This
> patch addresses that by excluding IPv6 specific code where AF_INET6 is
> not defined.
> 6905552: libnet/nio portability issues
> Webrev: http://cr.openjdk.java.net/~chegar/6905552/webrev.0/webrev/
This looks okay to me. One thing I don't understand is the change to the
getMTU method in src/solaris/native/java/net/NetworkInterface.c - it
looks like this will fail on Solaris if IPv6 is not enabled - do I have
this right? In the same place there the comment "Try wIth an ..." can
probably be used.
Minor comment is that there are a few inconsistencies in the comments.
In some places it's #endif /* AF_INET6 */, others it is #endif //
AF_INET6, and no comments in the rest.
More information about the net-dev