Code Review 6935199: java/net regression tests failing with Assertions
Christopher Hegarty -Sun Microsystems Ireland
Christopher.Hegarty at Sun.COM
Tue Mar 16 07:14:25 PDT 2010
Michael McMahon wrote:
> Christopher Hegarty -Sun Microsystems Ireland wrote:
>> Michael McMahon wrote:
>>> Christopher Hegarty -Sun Microsystems Ireland wrote:
>>>> Hi Michael,
>>>> The following tests have incorrect assertion failures if run with
>>>> assertions enabled:
>>> Would it be better to just remove the assertion in the first one as
>> I don't think it really matters. The assertion just verifies that the
>> that the construction is not called with null, which seems reasonable.
>> It is just this one specific test that doesn't conform since it
>> verifies that NPE is actually thrown. If you feel strongly I can
>> remove it.
> Personally, I think it would be better. It doesn't seem right to have
> code that works
> around an assertion.
OK, I'll just remove it.
> - Michael
More information about the net-dev