Code Review 6935233: java/net/ServerSocket/AcceptCauseFileDescriptorLeak.java fails with modules build
Alan.Bateman at Sun.COM
Thu Mar 18 06:36:02 PDT 2010
Christopher Hegarty -Sun Microsystems Ireland wrote:
> Alan Bateman wrote:
>> It still seems very fragile and doesn't take into account that the
>> number of file descriptors might legitimately increase. How about
>> changing the test to use ulimit on Solaris/Linux to set the hard
>> limit to a smallish limit (say 1024) and then run and accept >1024
>> connections. If the original leak were to come back then it should
>> fail reliably.
> I've updated the webrev as per your suggestion.
This looks much better - thanks for doing this.
More information about the net-dev