RFR 8166359/9, java/net/URLPermission/nstest/lookup.sh fails if proxy is set, since fix for JDK-8161016

Felix Yang felix.yang at oracle.com
Wed Sep 21 02:31:38 UTC 2016

Hi Chris,

On 2016/9/20 23:22, Chris Hegarty wrote:
> Felix,
>> On 20 Sep 2016, at 13:57, Felix Yang <felix.yang at oracle.com> wrote:
>> Hi all,
>>      please review the following test fix. It explicitly disables proxy to make sure the test not affected by different environment configuration.
>> Bug:
>>      https://bugs.openjdk.java.net/browse/JDK-8166359
>> Webrev:
>>       http://cr.openjdk.java.net/~xiaofeya/8166359/webrev.00/
> Since the test is setting a system-wide proxy selector, should it run in
> othervm mode ?
This test is shell test. I guess it is 'othervm' in nature, right?

> Also, it is not clear to me why the change from “test.src” to “user.dir”,
> since the file being access is actual in the test source root, right?
Two things here:
1. Not sure the test history, since no bug it associated. It looks that 
file is even not necessary.
     Could you suggest if it can be removed directly.
2. I remember modifying files under "test.src" is not suggested approach.

> -Chris.

More information about the net-dev mailing list