RFR(S): 8166850: No runtime error expected after calling NET_MapSocketOption
christoph.langer at sap.com
Thu Sep 29 13:05:53 UTC 2016
Thanks, Chris, for reviewing.
> -----Original Message-----
> From: Chris Hegarty [mailto:chris.hegarty at oracle.com]
> Sent: Donnerstag, 29. September 2016 13:40
> To: Langer, Christoph <christoph.langer at sap.com>
> Cc: net-dev at openjdk.java.net
> Subject: Re: RFR(S): 8166850: No runtime error expected after calling
> On 28 Sep 2016, at 16:39, Langer, Christoph <christoph.langer at sap.com>
> > Hi,
> > during my work on exception sites in the JDK, I spotted another minor place
> that should be fixed. In the Windows native implementations of
> DualStackPlainDatagramSocketImpl and DualStackPlainSocketImpl, there are
> calls to evaluate OS API errors after unsuccessful return of
> NET_MapSocketOption where this should not be done. Please review my fix. I
> also took the opportunity to clean up some indentations.
> > Bug: https://bugs.openjdk.java.net/browse/JDK-8166850
> > Webrev: http://cr.openjdk.java.net/~clanger/webrevs/8166850.0/
> The changes, and cleanup, look fine.
More information about the net-dev