<html>
<head>
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<p>Hi Christoph,</p>
<p>Code change looks good to me, but i am not an official reviewer.</p>
<p>Thanks,</p>
<p>Vyom<br>
</p>
<br>
<div class="moz-cite-prefix">On Monday 09 January 2017 11:26 AM,
Langer, Christoph wrote:<br>
</div>
<blockquote
cite="mid:ecc08294ccbf4f398532b614fbb374aa@DEWDFE13DE03.global.corp.sap"
type="cite">
<meta http-equiv="Content-Type" content="text/html;
charset=windows-1252">
<meta name="Generator" content="Microsoft Word 15 (filtered
medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri",sans-serif;
mso-fareast-language:EN-US;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:#0563C1;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:#954F72;
text-decoration:underline;}
span.EmailStyle17
{mso-style-type:personal;
font-family:"Calibri",sans-serif;
color:windowtext;}
span.EmailStyle18
{mso-style-type:personal-reply;
font-family:"Calibri",sans-serif;
color:#1F497D;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:612.0pt 792.0pt;
margin:72.0pt 72.0pt 72.0pt 72.0pt;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
<div class="WordSection1">
<p class="MsoNormal"><span style="color:#1F497D" lang="EN-US">Ping:
Please review this backport to JDK8.<o:p></o:p></span></p>
<p class="MsoNormal"><a moz-do-not-send="true"
name="_MailEndCompose"><span lang="EN-US"><o:p> </o:p></span></a></p>
<div style="border:none;border-left:solid blue 1.5pt;padding:0cm
0cm 0cm 4.0pt">
<div>
<div style="border:none;border-top:solid #E1E1E1
1.0pt;padding:3.0pt 0cm 0cm 0cm">
<p class="MsoNormal"><b><span
style="mso-fareast-language:DE" lang="EN-US">From:</span></b><span
style="mso-fareast-language:DE" lang="EN-US"> Langer,
Christoph
<br>
<b>Sent:</b> Donnerstag, 29. Dezember 2016 10:37<br>
<b>To:</b> <a class="moz-txt-link-abbreviated" href="mailto:net-dev@openjdk.java.net">net-dev@openjdk.java.net</a>;
<a class="moz-txt-link-abbreviated" href="mailto:jdk8u-dev@openjdk.java.net">jdk8u-dev@openjdk.java.net</a><br>
<b>Subject:</b> [8u-dev]: Request for Review and
Approval: 8075484: SocketInputStream.socketRead0 can
hang even with soTimeout set<o:p></o:p></span></p>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal"><span lang="EN-US">Hi,<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">please review (and
eventually approve) the change for downporting 8075484.<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">Webrev for 8u-dev: <a
moz-do-not-send="true"
href="http://cr.openjdk.java.net/%7Eclanger/webrevs/8075484.8udev/">
<a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~clanger/webrevs/8075484.8udev/">http://cr.openjdk.java.net/~clanger/webrevs/8075484.8udev/</a></a><o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">Bug: <a
moz-do-not-send="true"
href="https://bugs.openjdk.java.net/browse/JDK-8075484">
<a class="moz-txt-link-freetext" href="https://bugs.openjdk.java.net/browse/JDK-8075484">https://bugs.openjdk.java.net/browse/JDK-8075484</a></a><o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">JDK9 Change: </span><a
moz-do-not-send="true"
href="http://hg.openjdk.java.net/jdk9/dev/jdk/rev/af17b6bc08dd"><span
lang="EN-US"><a class="moz-txt-link-freetext" href="http://hg.openjdk.java.net/jdk9/dev/jdk/rev/af17b6bc08dd">http://hg.openjdk.java.net/jdk9/dev/jdk/rev/af17b6bc08dd</a></span></a><span
lang="EN-US"><o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">JDK9 Review Thread(s):<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"> <a
moz-do-not-send="true"
href="http://mail.openjdk.java.net/pipermail/net-dev/2016-August/010171.html"><a class="moz-txt-link-freetext" href="http://mail.openjdk.java.net/pipermail/net-dev/2016-August/010171.html">http://mail.openjdk.java.net/pipermail/net-dev/2016-August/010171.html</a></a><o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"> <a
moz-do-not-send="true"
href="http://mail.openjdk.java.net/pipermail/net-dev/2016-September/010201.html"><a class="moz-txt-link-freetext" href="http://mail.openjdk.java.net/pipermail/net-dev/2016-September/010201.html">http://mail.openjdk.java.net/pipermail/net-dev/2016-September/010201.html</a></a><o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">We had customer
reports who ran into that issue with Java 8. So this
should be downported.<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">The problem is, that
the fix does not apply to Solaris as Solaris needs some
calls into hotspot. This is because in JDK 8 the flag for
interruptible IO is still supported (though deprecated).
But I think it is still worthwile to bring this down for
the other platforms which I’m proposing with my changeset.
So I extracted the new code manually from the JDK9
changeset and made it fit into JDK8 coding.<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">Thanks & Best
regards<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">Christoph<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
</div>
</div>
</blockquote>
<br>
</body>
</html>