DoubleBuffer.compareTo is not anti-symmetric
martinrb at google.com
Tue Nov 24 18:23:46 PST 2009
On Tue, Nov 24, 2009 at 03:26, Alan Bateman <Alan.Bateman at sun.com> wrote:
> Martin Buchholz wrote:
> Kelly renamed X-Buffer.java to X-Buffer.java.template a few weeks ago (just
> noticed that your webrev is against X-Buffer.java).
I was surprised that my mq upgrade went without a conflict.
The rename Just Worked!
I improved the spec to make it hopefully less clumsy,
and added some more tests as well.
>> It made no sense to me that "char" would have a fulltype of
>> "character", but "int" didn't have a fulltype of "integer".
>> I fixed that, and that allowed $Fulltype$ to be usable in
>> the source.
>> case $type in
>> char) fulltype=character;;
>> + int) fulltype=integer;;
>> *) fulltype=$type;;
> I can't see any problem doing this but can you compare the generated code to
> make sure it is the same?
I'm pretty sure that the only change is in the doc for CharBuffer.java.
It now talks about "char buffer" instead of "character buffer",
which is (sadly) a clear improvement.
I'd like to commit my latest version. webrev regenerated.
(Unless of course we suddenly become bold enough to
switch to saner semantics)
More information about the nio-dev