-Werror in make/java/sun_nio/Makefile

Andrew John Hughes gnu_andrew at member.fsf.org
Mon Feb 1 06:51:07 PST 2010

On 1 February 2010 12:49, Alan Bateman <Alan.Bateman at sun.com> wrote:
> Andrew John Hughes wrote:
>> :
>> Ok, that's what I've done in this webrev:
>> http://cr.openjdk.java.net/~andrew/warnings/webrev.01/
>> It also fixes a number of unchecked and redundant cast warnings that
>> occur when building with JAVAC_MAX_WARNINGS=true.  With this patch,
>> sun_io now compiles when JAVAC_MAX_WARNINGS=true.
>> Does this look ok?
> Looks good to me. I think this is first webrev that I've reviewed with
> changes that make use of the diamond operator.
> I've created a bug to track this:
>  6921740: Eliminate warnings from sun.io converters and allow compiling with
> -Alan.

Great!  Is it ok to push this now or does it need further review?

Andrew :-)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

Support Free Java!
Contribute to GNU Classpath and the OpenJDK

PGP Key: 94EFD9D8 (http://subkeys.pgp.net)
Fingerprint: F8EF F1EA 401E 2E60 15FA  7927 142C 2591 94EF D9D8

More information about the nio-dev mailing list