Review request for #7087549
Alan.Bateman at oracle.com
Sat Dec 17 08:44:19 PST 2011
On 16/12/2011 18:46, Brandon Passanisi wrote:
> Hi Alan. Thank you for your comments. I have created an updated
> webrev based on your suggestions for the alias to review. Here's the
> url of the updated webrev followed by a summary of the changes:
> Webrev: http://cr.openjdk.java.net/~alanb/7087549/webrev/
> Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7087549
> Summary of changes:
> 1. The test now uses a PassThroughProvider with a custom option, as
> you have suggested in this review thread.
> 2. I renamed the test file from TestOpenOptions.java to
> CustomOptions.java to reflect the changes to the test.
> 3. I changed some of the text in the comments give them better
> 4. Some cosmetic changes, including formatting, the use of braces, and
> moving of some comments.
Looking at the again, the test needs to override newByteChannel rather
than newInputStream (sorry I said newInputStream in the last mail). By
overriding newInputStream and dropping the IGNORE option it means that
the code that you fixed in FileSystemProvider's newInputStream will not
be executed. One other thing I noticed is that the test description is
missing @library (the test is using TestUtil which is in the parent
I don't think it's worth spending too much more time on this one so I'll
fix up the above issues in the test and push it listing you as contributor.
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the nio-dev