7006126: (fs) Updates to file system API (1/2011)

Chris Hegarty chris.hegarty at oracle.com
Thu Jan 27 08:28:20 PST 2011


I really like these changes. Files is a one stop shop for file 
operations, and should really simplify applications that use it. I also 
really like the convenience methods for common use cases.

I've taken a walk through all of the source changes and given my 
comments in a private mail. Mostly small/trivial issues, typos, 
incorrect links, etc. Thanks for fixing these.

I'm finished with reviewing this and give my approval.


On 20/01/2011 15:06, Alan Bateman wrote:
> Just to follow-up on last week's mail [1].
> The webrev with the changes is here:
> http://cr.openjdk.java.net/~alanb/7006126/
> On first glance it might seem a lot but most of the changes is
> refactoring/moving the methods and so it looks more than it really is.
> In particular, the changes to AbstractFileSystem from L65 is mostly just
> moved from AbstractPath. The "new" code in UnixFileSystem from L400
> onwards was moved from UnixPath. The "new" code in WindowsFileSystem
> from L315 onwards was moved from WindowsPath. In Files then the bulk of
> the "additions" were in Path previously with most of the new code at
> L2250 onwards.
> Partial reviews are welcome (just let me know which files/areas you have
> reviewed so that I can keep track).
> Thanks,
> Alan.
> [1] http://mail.openjdk.java.net/pipermail/nio-dev/2011-January/001174.html

More information about the nio-dev mailing list