7023403: (ch) sun.nio.ch.SolarisEventPort.startPoll failed with AssertionError

Rémi Forax forax at univ-mlv.fr
Fri Mar 4 11:43:43 PST 2011

On 03/04/2011 08:32 PM, Alan Bateman wrote:
> Rémi Forax wrote:
>> In my opinion, it's more readable to do an instanceof 
>> AsynchronousCloseException.
>> Even if AsynchronousCloseException inherits from ClosedChannelException.
> Okay, either will work here.
>> Also, it can be more efficient to do the instanceof check in 
>> lockAndUpdateEvents;
> That would mean that lockAndUpdateEvents would need to know about the 
> exception, whereas I think it's a bit more understandable now.

I agree.

> -Alan

so looks good to me.


More information about the nio-dev mailing list