Fw: Patch for File Scanning
Alan.Bateman at oracle.com
Thu Oct 27 02:46:07 PDT 2011
On 27/10/2011 01:18, Mike Skells wrote:
> Hi Alan,
> After running it a couple of dozen times, the timings seem to be about
> 20-30 ms slower but the difference between successive runs (the error
> tolerance) is 5-10 ms, so it seems to have captured the significant
> majority of the change.
Thanks for checking, that's what I guessed would be the case.
> WRT to the changes for WindowsPathWithAttributes is it not worth
> having some mechanism to avoid Path.getParent() causing additional
> object creation, and potential loss of the file attributes, as the
> information is available at the time of construction of the object?
> This could be done as a WeakRefernce to avoid memory usage utilisation
The parent directory is already reported to the preVisitDirectory method
so it really depends on the FileVisitor implementation to know if this
will help. More generally I think there's a project here to choose the
right (internal) representation and come up with the right balance
(meaning space/performance tradeoff) for these path access methods. If
it's okay with you I think we should separate that from the jar
tool/file tree walking work.
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the nio-dev