[PATCH] 8004789 : (zipfs) zip provider doesn't work correctly with file systems providers rather than the default

Xueming Shen xueming.shen at oracle.com
Mon Dec 10 11:10:11 PST 2012

On 12/10/2012 03:06 AM, Alan Bateman wrote:
> On 09/12/2012 22:08, Philippe Marschall wrote:
>> Hi
>> As discussed previously [1] here are the patches against JDK 7 and 8
>> to make the ZipFileSystem provider use Files#createTempFile instead of
>> File#createTempFile. This causes the temporary file to be created on
>> the same file system as the ZIP file resides on. This makes it
>> possible to run the zipfs provider on a file system other than the
>> default one.
>> This patch does not include any tests but I also could not find any
>> existing ones. If somebody wants tests I'd be happy to supply them
>> once instructed who to do them and where to put them.
> Thanks for the patch, it looks okay to me. I see that toAbsolutePath is used but that isn't actually required. Sherman - do you want to sponsor this?
> The tests for the zip provider are in jdk/test/demo/zipfs. As the scenario requires three file system providers to demonstrate then it would be a lot of work to create a test case, in which case I think it's okay to let it out for this one.
> -Alan

I will sponsor the patch.


More information about the nio-dev mailing list