Review Request : JDK-8002306, (se) fails if invoked with thread interrupt status set [win]

Dan Xu dan.xu at
Wed Dec 19 12:05:51 PST 2012

Hi Alan,

Your suggestion makes the code much leaner. I have updated the fix at, 

Please help review it. Thanks!


On 12/18/2012 01:17 PM, Alan Bateman wrote:
> On 18/12/2012 19:32, Dan Xu wrote:
>> :
>> I have updated my fix at, 
>> <>.
>> It removes checks of null or isConnected, and also addresses a 
>> potential race situation by using an uninterruptible thread to 
>> establish the loopback connections, which is the last resort to solve 
>> the connection failures. In addition, the test is also updated to 
>> test the pipe directly. Please review the new changes. Thanks!
>> -Dan
> I think the approach is good but I'd prefer if we didn't duplicate the 
> code to establish the loopback connection. If you could put this into 
> own class (that implements Runnable) then you could invoke it directly 
> first, and if that is interrupted then the background thread can 
> invoke it from its run method.
> -Alan

-------------- next part --------------
An HTML attachment was scrubbed...

More information about the nio-dev mailing list