Please review: Add EACCES check to the return value of fcntl()
littlee at linux.vnet.ibm.com
Fri Feb 17 00:21:22 PST 2012
On 02/15/2012 04:06 PM, Alan Bateman wrote:
> On 15/02/2012 07:11, Charles Lee wrote:
>> Hi guys,
>> Patch @ http://cr.openjdk.java.net/~littlee/OJDK-327/webrev.00/
>> The patch is mainly about add the EACCES when check the errno of
>> fcntl with command F_SETLK.
>> From the man page:
>> /If a conflicting lock is held by another process, this call returns
>> -1 and sets errno to EACCES or EAGAIN.
>> /I propose to add the EACCES check. Would anyone help to review the
> Looks okay to me although I'm surprised we haven't run into this
> before (the file locking code is there since jdk1.4). Are you seeing
> this only on AIX or have you seen it on Linux/Solaris too?
Do I have your thumb up for this patch? Is it ok for me to commit it?
By the way, I have create a sunbug @
http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7146506 . Should I
wait for this bug coming online?
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the nio-dev