RFR for JDK-6963118 Intermittent test failure: test/java/nio/channels/Selector/Wakeup.java fail intermittently (win)
srikalyan.chandrashekar at oracle.com
Thu Dec 19 11:16:44 PST 2013
Hi Alan, Thanks for your time and review.
On 12/19/13, 10:05 AM, Alan Bateman wrote:
> Thanks for looking at this one, this is a JDK 1.4-era test that has
> been asking for attention for some time.
> The test has been on the exclude list (jdk/test/ProblemList.txt) for a
> long time and we should remove it as part of this change.
Added to the patch.
> As regards the changes then the having the main thread yeild for the
> sleeper thread looks okay. For consistency then it would be good to
> put them after the comment so that it matches the other places.
> On the thresholds in check then I agree that 1s is insufficient. I
> think I would probably got 10 or 20 seconds just to be sure (extreme
> cases where you are in -Xcomp and competing with a virus checker).
Changed to 10sec from 3sec.
> Looking at the test then it probably could be re-written too (maybe
> using Phaser) but that might be too much for now.
> Oh, and I'm happy to sponsor this for you.
Thanks and the new webrev is available here
More information about the nio-dev