RFR : (fs) bad error handling in java.base/unix/native/libnio/fs/UnixNativeDispatcher.c
ivan.gerasimov at oracle.com
Mon Aug 25 14:50:31 UTC 2014
On 25.08.2014 17:17, Alan Bateman wrote:
> On 25/08/2014 14:13, Ivan Gerasimov wrote:
>> Here's the comment I've added to UnixNativeDispatcher.fclose:
>> /* NOTE: fclose() wrapper is only used with read-only streams.
>> * If it ever is used with write streams, it might be better to add
>> * RESTARTABLE(fflush(fp)) before closing, to make sure the stream
>> * is completely written even if fclose() failed.
> This seems okay but I can't tell if you are adding this to the .java
> or .c file.
This is in .c file.
Here's the webrev for the sake of clarity:
More information about the nio-dev