RFR of 8074821: Resolve disabled warnings for libnio
brian.burkhalter at oracle.com
Wed Aug 19 17:45:17 UTC 2015
On Aug 19, 2015, at 2:01 AM, Alan Bateman <Alan.Bateman at oracle.com> wrote:
> On 18/08/2015 01:55, Brian Burkhalter wrote:
>> It differs from the prior one in the addition of the lines
>> +// GetVersionEx is deprecated; disable the warning until a replacement is found
>> +#pragma warning(disable : 4996)
>> just before the functions in which GetVersionEx() is invoked in the Windows source code of Iocp.c and Net.c. There is precedence elsewhere in the source for using this approach. I don’t think that in the Net.c source it is necessary to repeat the pragma directive  but it does serve to emphasize the functions which call GetVersionEx().
> I think we can drop some of these GetVersionEx usages in Net.c because they date back to Windows XP and older.
I have an updated patch here:
The differences from the previous one are:
* Net.java: the comment is modified at line 394 to reflect the change to Java_sun_nio_ch_Net_isExclusiveBindAvailable
in Net.c below.
* Iocp.c: the function Java_sun_nio_ch_Iocp_osMajorVersion is removed as it is not specified in Iocp.java nor
referenced anywhere else.
* Net.c: the uses of GetVersionEx() are removed as they are no longer pertinent to Windows > Windows XP.
All platforms build and pass jdk_nio regression tests.
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the nio-dev