RFR of 8087304: (ch) java/nio/channels/DatagramChannel/EmptyBuffer.java received 4 times while expected 3
brian.burkhalter at oracle.com
Tue Jun 16 15:29:07 UTC 2015
On Jun 16, 2015, at 1:04 AM, Chris Hegarty <chris.hegarty at oracle.com> wrote:
> This latest version looks good to me Brian. Nice and tidy.
> Some minor comments, that if accepted do not need another webrev:
> 1) clientAddress does not need to be volatile, I think it can be just final.
> 2) A little subjective, but I would not add the bugId to the @bug tag.
> This is but a testcase issue, not a product issue.
On Jun 16, 2015, at 3:20 AM, Alan Bateman <Alan.Bateman at oracle.com> wrote:
> Good, this is what I assumed it would take.
> As Chris has noted, clientAddress can be final. Otherwise looks good to me.
I’ll make the two changes suggested by Chris prior to pushing the fix but will not post another webrev.
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the nio-dev