RFR of 8129632: (fs) Files.probeContentType returns null on Mac OS X
brian.burkhalter at oracle.com
Mon Jun 29 15:35:51 UTC 2015
On Jun 29, 2015, at 3:32 AM, Alan Bateman <Alan.Bateman at oracle.com> wrote:
> This mostly looks good.
> In NioLibrary.gmk then you probably should split the LDFLAGS_SUFFIX_macosx line to avoid the long line.
> The protected static method in sun.nio.fs.AbstractFileTypeDetector is a bit inconsistent. Can you change this to be final and change the comment so that it's consistent with the other final method.
> Are you confident that the update test and the image types will pass everywhere? We've had to dial-down the tests in this area because there is no guarantee that all test machines will the mappings.
I’ve run these through one of the regression test queues several times as well as several VMs and this set is what it boiled down to. I can try one or two other queues before pushing.
> Also in the delete then you can use Files.delete(file).
> For Windows then startingWith("Windows") is commonly used.
In the various tests what is checked for in “os.name” seems to be all over the map vis-a-vis upper and lower case, startsWith() and contains().
> The comments in UTIFileTypeDetector.c need to be cleaned up before this is pushed. I don't think you need to reference MacOSXPreferencesFile.m as it's only a tiny amount of duplication. Bets to keep these /* */ style to be consistent with the other code.
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the nio-dev