RFR of 8129632: (fs) Files.probeContentType returns null on Mac OS X

Alan Bateman Alan.Bateman at oracle.com
Tue Jun 30 08:24:48 UTC 2015

On 30/06/2015 02:07, Brian Burkhalter wrote:
> An updated patch is viewable here:
> http://cr.openjdk.java.net/~bpb/8129632/webrev.01/ 
> <http://cr.openjdk.java.net/%7Ebpb/8129632/webrev.01/>
This looks much better.

Minor nits:

- getExtension has been moved to AbstractFileTypeDetector, can it be 
changed to be non-static? Also "Gets the extension" would be nicer as 
"Returns the extension".

- In the test then you are using equals("Mac OS X") the Apple 
recommendation is to use contains("OS X"). This may up during the Mac 
port a few years ago.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/nio-dev/attachments/20150630/f812fb5d/attachment.html>

More information about the nio-dev mailing list