RFR of 8129632: (fs) Files.probeContentType returns null on Mac OS X
brian.burkhalter at oracle.com
Tue Jun 30 16:41:44 UTC 2015
On Jun 30, 2015, at 8:33 AM, Brian Burkhalter <brian.burkhalter at oracle.com> wrote:
>> Minor nits:
>> - getExtension has been moved to AbstractFileTypeDetector, can it be changed to be non-static? Also "Gets the extension" would be nicer as "Returns the extension”.
> Will make those changes.
>> - In the test then you are using equals("Mac OS X") the Apple recommendation is to use contains("OS X"). This may up during the Mac port a few years ago.
> I’ll change it.
Here is an updated patch with the foregoing changes applied:
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the nio-dev