RFR 8156931: java.nio.Buffer tests cleanup

Pavel Rappo pavel.rappo at oracle.com
Fri May 13 14:19:33 UTC 2016

Hi Alan,

Thanks for looking into this! I have fixed excessively long lines and removed
clarifying curly braces where not needed.


> On 13 May 2016, at 13:00, Alan Bateman <Alan.Bateman at oracle.com> wrote:
> On 13/05/2016 12:39, Pavel Rappo wrote:
>> Hi,
>> Could you please review my change for JDK-8156931?
>>    http://cr.openjdk.java.net/~prappo/8156931/webrev.00/
>> It's a pass through before updating tests for "(bf) Hoist slice and duplicate
>> methods up to java.nio.Buffer"
>>    https://bugs.openjdk.java.net/browse/JDK-8150785
> This looks okay except that I wouldn't bother with the extra braces.
> Would you mind fixing testAlign while you are there? The tests for this introduce very long lines and so means annoying horizontal scrolling when looking at the diffs.
> -Alan

More information about the nio-dev mailing list