RFR : 8186517: sun.nio.cs.StandardCharsets$Aliases and ClassMap can be lazily loaded
peter.levart at gmail.com
Thu Aug 24 21:25:17 UTC 2017
On 08/24/2017 11:18 PM, Peter Levart wrote:
>> Manually verified that generated charsets look correct and ran all
>> charset tests without issue.
>>> Should be a nice reduction in retained objects on minimal apps.
>> 425 fewer objects allocated, -16.5Kb.
> Very nice!
> The synchronization issue with iteration and unsynchronized lookup()
> still remains, and it's awkward that init() still has to "patch" the
> aliases (must the hack remain in place?), but that could be solved in
> a separate followup issue as well as optimization for public
> The startup performance issue has been nicely handled, so this looks
> good to me, Claes.
Maybe just a nit: the constructors of UTF_8, US_ASCII and ISO_8859_1
could be made private since they should now never need to be invoked
from outside of class and if there is a bug in code and they do get
invoked, it's better to see the exception early and fix it...
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the nio-dev