JDK 9 RFR of 8172547: (se) Selector.select(Long.MAX_VALUE) fires repeatedly
christoph.langer at sap.com
Mon Jan 16 08:23:22 UTC 2017
the fix and test look fine, +1.
Minor remark for the comment in src/java.base/windows/native/libnio/ch/WindowsSelectorImpl.c:
82 // signed 64-bit jlong needs to clamped
-> Should be
82 // signed 64-bit jlong needs to be clamped
From: nio-dev [mailto:nio-dev-bounces at openjdk.java.net] On Behalf Of Brian Burkhalter
Sent: Freitag, 13. Januar 2017 23:57
To: Roger Riggs <Roger.Riggs at oracle.com>
Cc: nio-dev at openjdk.java.net
Subject: Re: JDK 9 RFR of 8172547: (se) Selector.select(Long.MAX_VALUE) fires repeatedly
Thanks for the comments. Here is an update which takes them into account:
On Jan 13, 2017, at 2:23 PM, Roger Riggs <Roger.Riggs at Oracle.com<mailto:Roger.Riggs at Oracle.com>> wrote:
- 35: for consistency use the '_' in both constants
- 40: you may want isTimedOut and theException to be volatile since it is written and read by different threads
Comment on the existing code: line 77.
Using Thread.join(SLEEP_MILLIES) would continue quicker in the case of an exception or for the timeout=0 case.
It would knock some time off the clock time for the test.
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the nio-dev