RFR JDK-8172921: Zip filesystem performance improvement and code cleanup

Xueming Shen xueming.shen at oracle.com
Tue Jan 17 23:56:12 UTC 2017

On 1/17/17, 3:24 PM, Claes Redestad wrote:
> Looks good - I stumbled on the ZipPath::getResolved changes at first,
> but they seem sound and I can see how the previous test was likely to
> unnecessarily create a new byte[] on most regular files.
It's a little hacky to only go into resolve0 for "." or ".." with a 
tailing "/"
to avoid a single ".", such in Foo.class, to trigger the expensive 

> Nits:
> Code formatting seems unintentionally messed up in places, especially
> ZipCoder.java.

ran the normalizer on the source code.
> ZipCoder$UTF8 has a chunk of commented out code that should likely be
> removed.


More information about the nio-dev mailing list