JDK 10 RFR of JDK-8181396: Refactor shell test java/nio/file/Files/delete_on_close.sh to java
amy.lu at oracle.com
Tue Jun 6 08:48:27 UTC 2017
On 6/6/17 3:46 PM, Alan Bateman wrote:
> On 06/06/2017 02:34, Amy Lu wrote:
>> On 6/5/17 10:52 PM, Alan Bateman wrote:
>>>> webrev: http://cr.openjdk.java.net/~amlu/8181396/webrev.00/
>>> I think it's a bit confusing to have both DeleteOnClose and
>>> DeleteOnTerminate, esp. when DeleteOnTerminate creates a file with
>>> DELETE_ON_CLOSE. Instead couldn't DeleteOnClose just launch itself
>>> to create the file?
>> Please review the updated webrev:
> This looks okay except for "/java/nio/file" in the @library value - I
> assume that is not needed.
This is for ../TestUtil.java, which is jdk/test/java/nio/file/TestUtil.java
Thank you for reviewing.
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the nio-dev