8179527: Ineffective use of volatile hurts performance of Charset.atBugLevel()
christoph.langer at sap.com
Thu Jun 29 14:31:45 UTC 2017
thanks, I've implemented your suggestions in the CSR. I've even renamed it to better reflect that it is about dropping property sun.nio.cs.bugLevel. Don't know if this is the right thing to do - or must the CSR title always match the Bug?
I'm also not allowed to delete attachments in the bug system. So, please remove the patch attachment for me, if you like.
> -----Original Message-----
> From: Alan Bateman [mailto:Alan.Bateman at oracle.com]
> Sent: Donnerstag, 29. Juni 2017 15:49
> To: Langer, Christoph <christoph.langer at sap.com>; nio-
> dev at openjdk.java.net
> Cc: core-libs-dev <core-libs-dev at openjdk.java.net>
> Subject: Re: 8179527: Ineffective use of volatile hurts performance of
> On 29/06/2017 13:07, Langer, Christoph wrote:
> > Hi,
> > can somebody please review my CSR:
> https://bugs.openjdk.java.net/browse/JDK-8183116 ?
> > I think there should be some button to add yourself as reviewer in the CSR
> bug - though I have never done such a thing myself. You'll probably know
> what to do :)
> A few things that could be fixed up before finalizing:
> 1. Link to both JDK-4853350 and JDK-4786884 as background.
> 2. The CSR is for the interface change, in this case, dropping the
> property, so I think you can drop the patch.
> 3. I assume you mean "JDK 1.4" rather than "Java 1.4".
More information about the nio-dev