RFR 8196535: Remove support for pre-Java 6 non-JVM-wide file locking

Roger Riggs Roger.Riggs at Oracle.com
Fri Feb 2 15:29:06 UTC 2018

Hi Brian,

Nice cleanup.

FileLockTable: line 80: typo "the a" -> "the"

FileLockTable:89:  the constructor should be private to avoid an end-run 
around the factory method.

While editing FileLockTable.java perhaps convert imports to single 
imports instead of .*... your call.

I'm assuming there were no tests for the old setting since there none in 
the review.

FileChannelImpl.java:1096: if the line doesn't need to be continued, 
maybe all on 1 line

Thanks, Roger

On 2/1/2018 6:40 PM, Brian Burkhalter wrote:
> https://bugs.openjdk.java.net/browse/JDK-8196535
> http://cr.openjdk.java.net/~bpb/8196535/webrev.00/
> This patch would remove support for the sun.nio.ch.disableSystemWideOverlappingFileLockCheck system property introduced in Java 6 to allow enabling pre-Java 6 behavior of checking for overlapping FileLocks opened on a FileChannel.
> Please note that this patch follows in sequence the patch proposed in [1] which still needs to pass review.
> Thanks,
> Brian
> [1] http://mail.openjdk.java.net/pipermail/nio-dev/2018-February/004667.html

More information about the nio-dev mailing list