RFR 8196908: (ch, fs) Safe publication of monitor objects and some others

Alan Bateman Alan.Bateman at oracle.com
Wed Feb 7 12:07:42 UTC 2018

On 07/02/2018 11:29, Pavel Rappo wrote:
> Hello,
> Please review the following change:
>   http://cr.openjdk.java.net/~prappo/8196908/webrev.00/
> This change addresses a number of issues with safe publication and covers some
> trivial typos. It seems that there are more similar issues in that area.
> However, I believe it is better to be rather conservative and firstly address
> issues that are pretty straightforward.
This look good, the only thing to check is the new asserts in 
SelectorImpl.implRegister and whether they push the method size over an 
inlining threshold. As they are useful when changing this area then you 
could add them commented out if you want.


More information about the nio-dev mailing list