RFR 8191416: (bf) DirectByteBuffer extends MappedByteBuffer, confuses instanceof tests

Alan Bateman Alan.Bateman at oracle.com
Fri Feb 9 08:41:58 UTC 2018

On 08/02/2018 19:44, Brian Burkhalter wrote:
> Updated patch with hasMappedFile() inlined:
> http://cr.openjdk.java.net/~bpb/8191416/webrev.01/ 
> <http://cr.openjdk.java.net/%7Ebpb/8191416/webrev.01/>
The changes to MBB are okay (I probably should drop the braces to keep 
it consistent with the existing code but it doesn't matter).

I assume the test should pass if the direct buffer is not a sub-class of 
MBB - maybe you've put that check in there to force the test to be 
updated in the that the class hierarchy is fixed?

The @summary line should probably be clear that it tests the MBB methods 
when a direct buffer is cast to a MBB. Future maintainers will not know 
what "UOE" is about.


More information about the nio-dev mailing list