RFR 8191416: (bf) DirectByteBuffer extends MappedByteBuffer, confuses instanceof tests

Brian Burkhalter brian.burkhalter at oracle.com
Fri Feb 9 15:29:08 UTC 2018

On Feb 9, 2018, at 12:41 AM, Alan Bateman <Alan.Bateman at oracle.com> wrote:

> The changes to MBB are okay (I probably should drop the braces to keep it consistent with the existing code but it doesn't matter).
> I assume the test should pass if the direct buffer is not a sub-class of MBB - maybe you've put that check in there to force the test to be updated in the that the class hierarchy is fixed?

The test fails (lines 36-37) if the DBB is not an instance of MBB.

> The @summary line should probably be clear that it tests the MBB methods when a direct buffer is cast to a MBB. Future maintainers will not know what "UOE" is about.

Will change once all other changes are agreed.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/nio-dev/attachments/20180209/64de35e3/attachment.html>

More information about the nio-dev mailing list