8198562: (ch) Separate blocking and non-blocking code paths (part 1)

Brian Burkhalter brian.burkhalter at oracle.com
Sat Feb 24 01:24:22 UTC 2018

On Feb 22, 2018, at 11:08 AM, Alan Bateman <Alan.Bateman at oracle.com> wrote:

> The webrev with the patch is here:
>    http://cr.openjdk.java.net/~alanb/8198562/webrev/

I think that this looks good, much cleaner and with better consistency. I do have a few minor suggestions which if accepted don’t necessitate any further review.

1. ServerSocketAdaptor

Use System.nanoTime() instead of System.currentTimeMillis() as in SocketAdaptor?

2. ServerSocketChannelImpl and SocketChannelImpl

In various locations replace "if (x == null) throw new NullPointerException();” with "Objects.requireNonNull();".

3. SocketChannelImpl

Lines 347-348 change to Objects.checkFromIndexSize(offset, length, dsts.length);

Lines 458-459 change to Objects.checkFromIndexSize(offset, length, srcs.length);

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/nio-dev/attachments/20180223/804738d2/attachment.html>

More information about the nio-dev mailing list