RFR of JDK-8207244, java/nio/channels/Selector/SelectWithConsumer.java testInterruptDuringSelect() fails intermittently
Alan.Bateman at oracle.com
Thu Jul 19 08:30:05 UTC 2018
On 19/07/2018 09:20, Hamlin Li wrote:
> I think it's better to have Utils.adjustTimeout, remember this issue
> is reported because of "select took 5204 ms", it could take longer
> than that. so I think we'd better to scale select timeout according to
> jtreg timeout factor.
>> I think the solution to this issue is a one-line fix - either drop
>> the assert (as it's not useful here) or change it to just check that
>> select didn't complete immediately.
> Sure, I think so too, will drop the assert.
> patch is updated in place:
Dropping the assert is fine but the use of adjustTimeout doesn't make
sense here. testInterruptDuringSelect is testing that interrupting
select or a timed select does not close the Selector, the timeout isn't
important is not nothing to do with timeout factor specified to jtreg.
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the nio-dev