8204915: (fs) Add some print diagnostics to java/nio/file/Files/CopyAndMove.java

Alan Bateman Alan.Bateman at oracle.com
Thu Jun 14 08:17:07 UTC 2018

On 12/06/2018 23:00, Brian Burkhalter wrote:
> https://bugs.openjdk.java.net/browse/JDK-8204915
> http://cr.openjdk.java.net/~bpb/8204915/webrev.00/
> Please review this simple, test-only change.
This is a bit ugly and I think needs a bit of discussion to fully 
understand what you are trying to do. There are a number of issues with 
the patch, the main being that it means getFileStore will be called for 
each copy/move scenario and we know this can be problematic on some of 
the test systems due to statle NFS mounts and other issues. I think it 
would be a lot cleaner to just have the main method print the test 
directories as it does the setup for all the tests.

The other issue is "catch Exception" (x2) to print the various 
attributes. These look really ugly. Are these asserts really failing? I 
assume you know which assert is failing by the line number but if 
additional info is needed then it would be better to just add a message 
to the assert.


More information about the nio-dev mailing list