Callback Based Selectors
Alan.Bateman at oracle.com
Fri Jun 15 14:28:57 UTC 2018
On 14/06/2018 01:53, Brian Burkhalter wrote:
> What is the significance, if any, of moving the old lines 203-204 to be ahead of the new lines 198-201 versus being after the old lines 190-200?
It's not significant. The only important thing is that the keys are
re-queued before any actions are invoked as the action is arbitrary code
that could cause the selection operation to terminate with an exception.
> SelectWithConsumer test:
> 142: I assume the n == 1 assertion is to allow line 143 or 144 to identify which action was *not* performed.
> 214: Blank line
> 305: Comment -> “Test invoking select operation with interrupt status set."
> 387: Comment is inconsistent with the key set *not* being locked.
The test dates back to the prototype in April and needed update to cover
the 3 methods. I've done that and refreshed the webrev. There are no
changes to implementation (that you've already reviewed), just minor
fixes to the javadoc that you pointed out and replacing the
SelectWithConsumer test with a more complete test.
The CSR has been approved so I think we are close to the finish line on
More information about the nio-dev