Callback Based Selectors
brian.burkhalter at oracle.com
Fri Jun 15 20:31:59 UTC 2018
On Jun 15, 2018, at 7:28 AM, Alan Bateman <Alan.Bateman at oracle.com> wrote:
> There are no changes to implementation (that you've already reviewed), just minor fixes to the javadoc that you pointed out and replacing the SelectWithConsumer test with a more complete test.
> The CSR has been approved so I think we are close to the finish line on this one.
Minor comments on the SelectWithConsumer test:
56: checks -> check
538: removes -> remove
In the assertTrue() calls which involve a duration check, might it be useful to print the value of ‘duration’ if the assertion fails?
I think that this can go forward without further review if the foregoing items are changed.
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the nio-dev