Callback Based Selectors
brian.burkhalter at oracle.com
Sat Jun 16 18:21:57 UTC 2018
All good! Nice to get this one in.
----- Original Message -----
From: Alan.Bateman at oracle.com
To: brian.burkhalter at oracle.com
Cc: nio-dev at openjdk.java.net
Sent: Saturday, 16 June, 2018 2:28:52 AM GMT -08:00 US/Canada Pacific
Subject: Re: Callback Based Selectors
On 15/06/2018 21:31, Brian Burkhalter wrote:
Minor comments on the SelectWithConsumer test:
56: checks -> check
538: removes -> remove
In the assertTrue() calls which involve a duration check, might it be useful to print the value of ‘duration’ if the assertion fails?
Good idea. I'll change these asserts from `assertTrue(e)` to `assertTrue(e, "select took " + duration + " ms")` so the jtr file has the duration in the event of failure. I've run this test on all platforms several hundred times (with high concurrency) so I'm not expecting any issues but it is always tricky to test timed selection operations.
I think that this can go forward without further review if the foregoing items are changed.
Thanks, I'll get this pushed so that it's in jdk-11-ea+19.
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the nio-dev