8199611: (se) Minor selector implementation clean-up

Claes Redestad claes.redestad at oracle.com
Wed Mar 14 19:03:56 UTC 2018

On 2018-03-14 19:57, Alan Bateman wrote:
> On 14/03/2018 14:01, Alan Bateman wrote:
>> I have a number of patches for the Selector implementations, this 
>> include a few random cleanups that I would prefer to separate out.
>> The cleanup patch in the following webrev:
>> http://cr.openjdk.java.net/~alanb/8199611/webrev/index.html
> The review thread for JDK-8199437 on net-dev brought up the suggestion 
> for SelectionKey::toString to return a useful string for debugging. As 
> we do doing cleanups in this area then we can include it with the 
> changes here. I've updated the webrev in place, the only change is to 
> SelectionKeyImpl where I've added a toString method (SelectionKeyImpl 
> rather than SelectionKey as the implementation has easy access to the 
> interest and ready ops).
> -Alan 

Changes looks fine to me.


More information about the nio-dev mailing list