adding rsockets support into JDK
chris.hegarty at oracle.com
Wed Nov 14 08:31:11 UTC 2018
> On 14 Nov 2018, at 00:50, Lu, Yingqi <yingqi.lu at intel.com> wrote:
> Hi All,
> Here is the version 16 of the patch: http://cr.openjdk.java.net/~ylu/8195160.16.
This looks much better.
Just an initial comment. Why move the factory methods, from
jdk.net.Sockets to jdk.net.RdmaSockets? It is fine to do this,
just curious why.
I don’t think that jdk.net.RdmaSockets needs the static methods
for setting and retrieving the socket options. That can be done
through the Socket type itself. jdk.net.Sockets contains such
methods as they predate the more general option support on
the socket type itself. There are plans afoot to deprecate these
from jdk.net.Sockets as they are no longer needed, see
More information about the nio-dev