adding rsockets support into JDK

Lu, Yingqi at
Wed Nov 14 17:06:47 UTC 2018

Hi Chris,

Thank you for your feedback.

I was following the suggestion [1] from Joe Darcy to move the RDMA factory methods from to 

I will remove setOption and getOption methods from in the next version of the patch. At the meantime, please let me know if there is anything else missing from the current version.



>-----Original Message-----
>From: Chris Hegarty [mailto:chris.hegarty at]
>Sent: Wednesday, November 14, 2018 12:31 AM
>To: Lu, Yingqi < at>
>Cc: nio-dev at; Viswanathan, Sandhya
><sandhya.viswanathan at>; Aundhe, Shirish
><shirish.aundhe at>; Kaczmarek, Eric <eric.kaczmarek at>
>Subject: Re: adding rsockets support into JDK
>> On 14 Nov 2018, at 00:50, Lu, Yingqi < at> wrote:
>> Hi All,
>> Here is the version 16 of the patch:
>This looks much better.
>Just an initial comment. Why move the factory methods, from
>to It is fine to do this, just curious why.
>I don’t think that needs the static methods for setting
>and retrieving the socket options. That can be done through the Socket type
>itself. contains such methods as they predate the more
>general option support on the socket type itself. There are plans afoot to
>deprecate these from as they are no longer needed, see
>8189744 [1].

More information about the nio-dev mailing list