adding rsockets support into JDK
yingqi.lu at intel.com
Wed Nov 14 17:06:47 UTC 2018
Thank you for your feedback.
I was following the suggestion  from Joe Darcy to move the RDMA factory methods from jdk.net.Sockets to jdk.net.RDMASockets.
I will remove setOption and getOption methods from jdk.net.RdmaSockets in the next version of the patch. At the meantime, please let me know if there is anything else missing from the current version.
>From: Chris Hegarty [mailto:chris.hegarty at oracle.com]
>Sent: Wednesday, November 14, 2018 12:31 AM
>To: Lu, Yingqi <yingqi.lu at intel.com>
>Cc: nio-dev at openjdk.java.net; Viswanathan, Sandhya
><sandhya.viswanathan at intel.com>; Aundhe, Shirish
><shirish.aundhe at intel.com>; Kaczmarek, Eric <eric.kaczmarek at intel.com>
>Subject: Re: adding rsockets support into JDK
>> On 14 Nov 2018, at 00:50, Lu, Yingqi <yingqi.lu at intel.com> wrote:
>> Hi All,
>> Here is the version 16 of the patch:
>This looks much better.
>Just an initial comment. Why move the factory methods, from jdk.net.Sockets
>to jdk.net.RdmaSockets? It is fine to do this, just curious why.
>I don’t think that jdk.net.RdmaSockets needs the static methods for setting
>and retrieving the socket options. That can be done through the Socket type
>itself. jdk.net.Sockets contains such methods as they predate the more
>general option support on the socket type itself. There are plans afoot to
>deprecate these from jdk.net.Sockets as they are no longer needed, see
More information about the nio-dev